Merge pull request #50949 from SebTardif

snicoll · snicoll · commit 15bb54a41fd6 · 2026-07-16T11:08:56.000+02:00
Closes gh-50949 * fix/findmainclass-close-jarfile: Close JarFile when finding main class from archive
diff --git a/build-plugin/spring-boot-antlib/src/main/java/org/springframework/boot/ant/FindMainClass.java b/build-plugin/spring-boot-antlib/src/main/java/org/springframework/boot/ant/FindMainClass.java
@@ -71,8 +71,9 @@ public void execute() throws BuildException {
 			if (this.classesRoot.isDirectory()) {
 				return MainClassFinder.findSingleMainClass(this.classesRoot, SPRING_BOOT_APPLICATION_CLASS_NAME);
 			}
-			return MainClassFinder.findSingleMainClass(new JarFile(this.classesRoot), "/",
-					SPRING_BOOT_APPLICATION_CLASS_NAME);
+			try (JarFile jarFile = new JarFile(this.classesRoot)) {
+				return MainClassFinder.findSingleMainClass(jarFile, "/", SPRING_BOOT_APPLICATION_CLASS_NAME);
+			}
 		}
 		catch (IOException ex) {
 			throw new BuildException(ex);

Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,9 @@ public void execute() throws BuildException {`
`71`	`71`	`if (this.classesRoot.isDirectory()) {`
`72`	`72`	`return MainClassFinder.findSingleMainClass(this.classesRoot, SPRING_BOOT_APPLICATION_CLASS_NAME);`
`73`	`73`	`}`
`74`		`- return MainClassFinder.findSingleMainClass(new JarFile(this.classesRoot), "/",`
`75`		`- SPRING_BOOT_APPLICATION_CLASS_NAME);`
	`74`	`+ try (JarFile jarFile = new JarFile(this.classesRoot)) {`
	`75`	`+ return MainClassFinder.findSingleMainClass(jarFile, "/", SPRING_BOOT_APPLICATION_CLASS_NAME);`
	`76`	`+ }`
`76`	`77`	`}`
`77`	`78`	`catch (IOException ex) {`
`78`	`79`	`throw new BuildException(ex);`