Skip to content

Commit af926e2

Browse files
committed
Restore behavior of TestImage with Elasticsearch
See gh-46052
1 parent 4aff06a commit af926e2

File tree

5 files changed

+93
-6
lines changed

5 files changed

+93
-6
lines changed

spring-boot-project/spring-boot-docker-compose/src/dockerTest/java/org/springframework/boot/docker/compose/service/connection/elasticsearch/ElasticsearchDockerComposeConnectionDetailsFactoryIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
*/
3535
class ElasticsearchDockerComposeConnectionDetailsFactoryIntegrationTests {
3636

37-
@DockerComposeTest(composeFile = "elasticsearch-compose.yaml", image = TestImage.ELASTICSEARCH)
37+
@DockerComposeTest(composeFile = "elasticsearch-compose.yaml", image = TestImage.ELASTICSEARCH_9)
3838
void runCreatesConnectionDetails(ElasticsearchConnectionDetails connectionDetails) {
3939
assertConnectionDetails(connectionDetails);
4040
}

spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/ElasticsearchContainer9.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919
import org.testcontainers.elasticsearch.ElasticsearchContainer;
2020

2121
/**
22-
* A container suitable for testing Elasticsearch 8.
22+
* A container suitable for testing Elasticsearch 9.
2323
*
2424
* @author Dmytro Nosan
2525
*/
2626
public class ElasticsearchContainer9 extends ElasticsearchContainer {
2727

2828
public ElasticsearchContainer9() {
29-
super(TestImage.ELASTICSEARCH.toString());
29+
super(TestImage.ELASTICSEARCH_9.toString());
3030
addEnv("ES_JAVA_OPTS", "-Xms32m -Xmx512m");
3131
addEnv("xpack.security.enabled", "false");
3232
}

spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.testcontainers.containers.PulsarContainer;
3737
import org.testcontainers.containers.RabbitMQContainer;
3838
import org.testcontainers.couchbase.CouchbaseContainer;
39+
import org.testcontainers.elasticsearch.ElasticsearchContainer;
3940
import org.testcontainers.grafana.LgtmStackContainer;
4041
import org.testcontainers.kafka.ConfluentKafkaContainer;
4142
import org.testcontainers.ldap.LLdapContainer;
@@ -107,9 +108,22 @@ public enum TestImage {
107108
.withStartupTimeout(Duration.ofMinutes(10))),
108109

109110
/**
110-
* A container image suitable for testing Elasticsearch.
111+
* A container image suitable for testing Elasticsearch 7.
111112
*/
112-
ELASTICSEARCH("elasticsearch", "9.0.2"),
113+
ELASTICSEARCH("docker.elastic.co/elasticsearch/elasticsearch", "7.17.28", () -> ElasticsearchContainer.class,
114+
(container) -> ((ElasticsearchContainer) container).withEnv("ES_JAVA_OPTS", "-Xms32m -Xmx512m")
115+
.withStartupAttempts(5)
116+
.withStartupTimeout(Duration.ofMinutes(10))),
117+
118+
/**
119+
* A container image suitable for testing Elasticsearch 8.
120+
*/
121+
ELASTICSEARCH_8("elasticsearch", "8.17.1"),
122+
123+
/**
124+
* A container image suitable for testing Elasticsearch 9.
125+
*/
126+
ELASTICSEARCH_9("elasticsearch", "9.0.2"),
113127

114128
/**
115129
* A container image suitable for testing Grafana OTel LGTM.

spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-data-elasticsearch/src/dockerTest/java/smoketest/data/elasticsearch/SampleElasticsearch8ApplicationTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.util.UUID;
2020

21+
import org.junit.jupiter.api.Disabled;
2122
import org.junit.jupiter.api.Test;
2223
import org.testcontainers.elasticsearch.ElasticsearchContainer;
2324
import org.testcontainers.junit.jupiter.Container;
@@ -39,12 +40,13 @@
3940
*/
4041
@Testcontainers(disabledWithoutDocker = true)
4142
@DataElasticsearchTest
43+
@Disabled("Elasticsearch client v9 needs extra config with v8")
4244
class SampleElasticsearch8ApplicationTests {
4345

4446
@Container
4547
@ServiceConnection
4648
@Ssl
47-
static final ElasticsearchContainer elasticSearch = new ElasticsearchContainer(TestImage.ELASTICSEARCH.toString())
49+
static final ElasticsearchContainer elasticSearch = new ElasticsearchContainer(TestImage.ELASTICSEARCH_8.toString())
4850
.withPassword("my-custom-password");
4951

5052
@Autowired
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
/*
2+
* Copyright 2012-2025 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package smoketest.data.elasticsearch;
18+
19+
import java.util.UUID;
20+
21+
import org.junit.jupiter.api.Test;
22+
import org.testcontainers.elasticsearch.ElasticsearchContainer;
23+
import org.testcontainers.junit.jupiter.Container;
24+
import org.testcontainers.junit.jupiter.Testcontainers;
25+
26+
import org.springframework.beans.factory.annotation.Autowired;
27+
import org.springframework.boot.test.autoconfigure.data.elasticsearch.DataElasticsearchTest;
28+
import org.springframework.boot.testcontainers.service.connection.ServiceConnection;
29+
import org.springframework.boot.testcontainers.service.connection.Ssl;
30+
import org.springframework.boot.testsupport.container.TestImage;
31+
import org.springframework.data.elasticsearch.client.elc.ElasticsearchTemplate;
32+
33+
import static org.assertj.core.api.Assertions.assertThat;
34+
35+
/**
36+
* Smoke tests for Elasticsearch 9.
37+
*
38+
* @author Moritz Halbritter
39+
* @author Stephane Nicoll
40+
*/
41+
@Testcontainers(disabledWithoutDocker = true)
42+
@DataElasticsearchTest
43+
class SampleElasticsearch9ApplicationTests {
44+
45+
@Container
46+
@ServiceConnection
47+
@Ssl
48+
static final ElasticsearchContainer elasticSearch = new ElasticsearchContainer(TestImage.ELASTICSEARCH_9.toString())
49+
.withPassword("my-custom-password");
50+
51+
@Autowired
52+
private ElasticsearchTemplate elasticsearchTemplate;
53+
54+
@Autowired
55+
private SampleRepository exampleRepository;
56+
57+
@Test
58+
void testRepository() {
59+
SampleDocument document = new SampleDocument();
60+
document.setText("Look, new @DataElasticsearchTest!");
61+
String id = UUID.randomUUID().toString();
62+
document.setId(id);
63+
SampleDocument savedDocument = this.exampleRepository.save(document);
64+
SampleDocument getDocument = this.elasticsearchTemplate.get(id, SampleDocument.class);
65+
assertThat(getDocument).isNotNull();
66+
assertThat(getDocument.getId()).isNotNull();
67+
assertThat(getDocument.getId()).isEqualTo(savedDocument.getId());
68+
this.exampleRepository.deleteAll();
69+
}
70+
71+
}

0 commit comments

Comments
 (0)