Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Forwarded header "by" parameter in ForwardedHeaderFilter #34654

Open
expuss2000 opened this issue Mar 25, 2025 · 0 comments
Open

Support Forwarded header "by" parameter in ForwardedHeaderFilter #34654

expuss2000 opened this issue Mar 25, 2025 · 0 comments
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
7.0.x

Comments

@expuss2000
Copy link

Spring doesn't parse the "by" parameter of the Forwarded header in ForwardedHeaderFilter.

According to RFC 7239:

The "by" parameter is used to disclose the interface where the request came in to the proxy server.

I think it should override getLocalAddr/getLocalPort of the HttpServletRequest: https://jakarta.ee/specifications/servlet/6.0/apidocs/jakarta.servlet/jakarta/servlet/servletrequest#getLocalAddr()

The syntax of a "by" value is the same of the "for" parameter.

Support for the "for" parameter has been added as requested in #23260
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 25, 2025
@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Mar 26, 2025
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 27, 2025
@bclozel bclozel added this to the 7.0.x milestone Mar 27, 2025
remeio added a commit to remeio/spring-framework that referenced this issue Mar 29, 2025
@remeio
Add support for X-Forwarded-By and Forwarded By
cf8032c 
See spring-projectsgh-34654, spring-projectsgh-23260

Signed-off-by: Mengqi Xu <[email protected]>
@remeio remeio mentioned this issue Mar 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.x
Development

No branches or pull requests
4 participants
@bclozel @jhoeller @spring-projects-issues @expuss2000