-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add hasScope as a valid SpEL expression to PreAuthorize #18151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright 2025-present the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.security.oauth2.core.authorization; | ||
|
|
||
| import org.springframework.security.authorization.AuthorizationManager; | ||
| import org.springframework.security.authorization.AuthorizationManagerFactory; | ||
| import org.springframework.security.authorization.DefaultAuthorizationManagerFactory; | ||
| import org.springframework.util.Assert; | ||
|
|
||
| /** | ||
| * A factory for creating different kinds of {@link AuthorizationManager} instances. | ||
| * | ||
| * @param <T> the type of object that the authorization check is being done on | ||
| * @author Ngoc Nhan | ||
| * @since 7.0 | ||
| */ | ||
| public final class DefaultOAuth2AuthorizationManagerFactory<T> implements OAuth2AuthorizationManagerFactory<T> { | ||
|
|
||
| private String scopePrefix = "SCOPE_"; | ||
|
|
||
| private final AuthorizationManagerFactory<T> authorizationManagerFactory; | ||
|
|
||
| public DefaultOAuth2AuthorizationManagerFactory() { | ||
| this(new DefaultAuthorizationManagerFactory<>()); | ||
| } | ||
|
|
||
| public DefaultOAuth2AuthorizationManagerFactory(AuthorizationManagerFactory<T> authorizationManagerFactory) { | ||
| Assert.notNull(authorizationManagerFactory, "authorizationManagerFactory can not be null"); | ||
| this.authorizationManagerFactory = authorizationManagerFactory; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the prefix used to create an authority name from a scope name. Can be an empty | ||
| * string. | ||
| * @param scopePrefix the scope prefix to use | ||
| */ | ||
| public void setScopePrefix(String scopePrefix) { | ||
| Assert.notNull(scopePrefix, "scopePrefix can not be null"); | ||
| this.scopePrefix = scopePrefix; | ||
| } | ||
|
|
||
| @Override | ||
| public AuthorizationManager<T> hasScope(String scope) { | ||
| Assert.notNull(scope, "scope can not be null"); | ||
| return hasAnyScope(scope); | ||
| } | ||
|
|
||
| @Override | ||
| public AuthorizationManager<T> hasAnyScope(String... scopes) { | ||
| Assert.notNull(scopes, "scopes can not be null"); | ||
| String[] mappedScopes = new String[scopes.length]; | ||
| for (int i = 0; i < scopes.length; i++) { | ||
| assertScope(scopes[i]); | ||
| mappedScopes[i] = this.scopePrefix + scopes[i]; | ||
| } | ||
| return this.authorizationManagerFactory.hasAnyAuthority(mappedScopes); | ||
| } | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will you please add |
||
| private void assertScope(String scope) { | ||
| Assert.isTrue(!scope.startsWith(this.scopePrefix), () -> scope + " should not start with '" + this.scopePrefix | ||
| + "' since '" + this.scopePrefix | ||
| + "' is automatically prepended when using hasScope and hasAnyScope. Consider using AuthorityAuthorizationManager#hasAuthority or #hasAnyAuthority instead."); | ||
| } | ||
|
|
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Copyright 2025-present the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.security.oauth2.core.authorization; | ||
|
|
||
| import org.springframework.security.authorization.AuthorizationManager; | ||
| import org.springframework.security.core.Authentication; | ||
|
|
||
| /** | ||
| * A factory for creating different kinds of {@link AuthorizationManager} instances. | ||
| * | ||
| * @param <T> the type of object that the authorization check is being done on | ||
| * @author Ngoc Nhan | ||
| * @since 7.0 | ||
|
||
| */ | ||
| public interface OAuth2AuthorizationManagerFactory<T> { | ||
|
|
||
| /** | ||
| * Create an {@link AuthorizationManager} that requires an {@link Authentication} to | ||
| * have a {@code SCOPE_scope} authority. | ||
| * | ||
| * <p> | ||
| * For example, if you call {@code hasScope("read")}, then this will require that each | ||
| * authentication have a {@link org.springframework.security.core.GrantedAuthority} | ||
| * whose value is {@code SCOPE_read}. | ||
| * | ||
| * <p> | ||
| * This would equivalent to calling | ||
| * {@code AuthorityAuthorizationManager#hasAuthority("SCOPE_read")}. | ||
| * @param scope the scope value to require | ||
| * @return an {@link AuthorizationManager} that requires a {@code "SCOPE_scope"} | ||
| * authority | ||
| */ | ||
| default AuthorizationManager<T> hasScope(String scope) { | ||
| return OAuth2AuthorizationManagers.hasScope(scope); | ||
| } | ||
|
|
||
| /** | ||
| * Create an {@link AuthorizationManager} that requires an {@link Authentication} to | ||
| * have at least one authority among {@code SCOPE_scope1}, {@code SCOPE_scope2}, ... | ||
| * {@code SCOPE_scopeN}. | ||
| * | ||
| * <p> | ||
| * For example, if you call {@code hasAnyScope("read", "write")}, then this will | ||
| * require that each authentication have at least a | ||
| * {@link org.springframework.security.core.GrantedAuthority} whose value is either | ||
| * {@code SCOPE_read} or {@code SCOPE_write}. | ||
| * | ||
| * <p> | ||
| * This would equivalent to calling | ||
| * {@code AuthorityAuthorizationManager#hasAnyAuthority("SCOPE_read", "SCOPE_write")}. | ||
| * @param scopes the scope values to allow | ||
| * @return an {@link AuthorizationManager} that requires at least one authority among | ||
| * {@code "SCOPE_scope1"}, {@code SCOPE_scope2}, ... {@code SCOPE_scopeN}. | ||
| */ | ||
| default AuthorizationManager<T> hasAnyScope(String... scopes) { | ||
| return OAuth2AuthorizationManagers.hasAnyScope(scopes); | ||
| } | ||
|
|
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright 2025-present the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.security.oauth2.core.authorization; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import org.springframework.security.authentication.TestingAuthenticationToken; | ||
| import org.springframework.security.authorization.AuthorityAuthorizationManager; | ||
| import org.springframework.security.authorization.AuthorizationManager; | ||
| import org.springframework.security.authorization.AuthorizationManagerFactories; | ||
| import org.springframework.security.authorization.AuthorizationResult; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** | ||
| * Tests for {@link OAuth2AuthorizationManagerFactory}. | ||
| * | ||
| * @author Ngoc Nhan | ||
| */ | ||
| public class OAuth2AuthorizationManagerFactoryTests { | ||
|
|
||
| @Test | ||
| public void hasScopeReturnsAuthorityAuthorizationManagerByDefault() { | ||
| OAuth2AuthorizationManagerFactory<String> factory = new DefaultOAuth2AuthorizationManagerFactory<>(); | ||
| AuthorizationManager<String> authorizationManager = factory.hasScope("message:read"); | ||
| assertThat(authorizationManager).isInstanceOf(AuthorityAuthorizationManager.class); | ||
| } | ||
|
|
||
| @Test | ||
| public void hasAnyScopeReturnsAuthorityAuthorizationManagerByDefault() { | ||
| OAuth2AuthorizationManagerFactory<String> factory = new DefaultOAuth2AuthorizationManagerFactory<>(); | ||
| AuthorizationManager<String> authorizationManager = factory.hasAnyScope("message:read", "message:write"); | ||
| assertThat(authorizationManager).isInstanceOf(AuthorityAuthorizationManager.class); | ||
| } | ||
|
|
||
| @Test | ||
| public void hasScopeWhenSetAuthorizationManagerFactories() { | ||
| DefaultOAuth2AuthorizationManagerFactory<String> factory = new DefaultOAuth2AuthorizationManagerFactory<>( | ||
| AuthorizationManagerFactories.<String>multiFactor().requireFactors("SCOPE_message:read").build()); | ||
| assertUserGranted(factory.hasScope("message:read")); | ||
| assertUserDenied(factory.hasScope("message:write")); | ||
| } | ||
|
|
||
| @Test | ||
| public void hasAnyScopeWhenSetAuthorizationManagerFactories() { | ||
| DefaultOAuth2AuthorizationManagerFactory<String> factory = new DefaultOAuth2AuthorizationManagerFactory<>( | ||
| AuthorizationManagerFactories.<String>multiFactor().requireFactors("SCOPE_message:read").build()); | ||
| assertUserGranted(factory.hasAnyScope("message:read")); | ||
| assertUserDenied(factory.hasAnyScope("message:write")); | ||
| } | ||
|
|
||
| private void assertUserGranted(AuthorizationManager<String> manager) { | ||
| AuthorizationResult authorizationResult = createAuthorizationResult(manager); | ||
| assertThat(authorizationResult).isNotNull(); | ||
| assertThat(authorizationResult.isGranted()).isTrue(); | ||
| } | ||
|
|
||
| private void assertUserDenied(AuthorizationManager<String> manager) { | ||
| AuthorizationResult authorizationResult = createAuthorizationResult(manager); | ||
| assertThat(authorizationResult).isNotNull(); | ||
| assertThat(authorizationResult.isGranted()).isFalse(); | ||
| } | ||
|
|
||
| private AuthorizationResult createAuthorizationResult(AuthorizationManager<String> manager) { | ||
| TestingAuthenticationToken authenticatedUser = new TestingAuthenticationToken("user", "pass", | ||
| "SCOPE_message:read"); | ||
| return manager.authorize(() -> authenticatedUser, ""); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you please update this to
7.1since 7 is already released?