PR: Return original font directory when font user installation load fails #273
Conversation
| # Regardless of the font file being actually removed | ||
| # since the load failed we need to return here where | ||
| # the font file is originally located. With that a | ||
| # `FontError` can be eventually raised with useful |
There was a problem hiding this comment.
Instead of returning fonts_directory below, why don't we raise a FontError there, saying that it was not possible to load a specific font? The error message could also use get_fonts_info to tell users what fonts they need to install manually and where they are located.
There was a problem hiding this comment.
After giving it some thought, if we raise FontError here the fallback logic to use system wide fonts will never be reached (since then always an error here will be raised). Maybe we should show instead a warning here and only in case we are unable to detect the font that failed being loaded is available from the system fonts directory? What do you think @ccordoba12 ?
There was a problem hiding this comment.
Last commit implements the idea above but let me know what you think
|
Sorry for closing this PR (I don't know why it happened). |
Fixes #264