-
Notifications
You must be signed in to change notification settings - Fork 48
Feature typeddict #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jvanasco
wants to merge
11
commits into
sqlalchemy:main
Choose a base branch
from
jvanasco:feature-typeddict
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature typeddict #270
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
134f44d
some typing updates
jvanasco 2d81ec1
extend proxy docs with typing
jvanasco ca15a91
more typing
jvanasco 1821cb9
remove CacheMutex as base class
jvanasco 23e69ed
* swtich TypedDicts to use total=False instead of NotRequired
jvanasco 9e4f016
more standardization and typing
jvanasco f3e42ff
tests for guard against region args mutation
jvanasco 0680d81
drop unnecessary cast
jvanasco 9eb6fc3
Merge branch 'main' into feature-typeddict
jvanasco fc67637
Merge branch 'main' into feature-typeddict
jvanasco 8711197
remove BackendArgsAntiMutationTest in favor of merged commit
jvanasco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this require a versionchanged note in the docstring and/or backward compat property what warns on access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. This is just correcting a docstring error. The docstring references
dead_timeout, the code useshashclient_dead_timeoutsee main:https://github.com/sqlalchemy/dogpile.cache/blob/main/dogpile/cache/backends/memcached.py#L610
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, the docs is of the dictionary not of the class attributes. got it.