-
Notifications
You must be signed in to change notification settings - Fork 41
Open
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is needed
Description
Describe the bug
SQLAlchemy release 1.4.33 added a new optional close: bool = True parameter to Engine#dispose().
This is not declared in the type definition, at
| def dispose(self) -> None: ... |
Expected behavior
The current type definition should declare the close parameter.
To Reproduce
Call Engine.dispose(close) and then run mypy on it with sqlalchemy2-stubs.
engine.dispose(close=False)Error
error: Too many arguments for "dispose" of "Engine"
Versions.
- OS: Darwin Kernel Version 21.6.0
- Python: 3.7.10
- SQLAlchemy: 1.4.39
- mypy: 0.931
- SQLAlchemy2-stubs: 0.0.2a29
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is needed