TEST: Remove use of port 8122

Port 8122 is already bound in AppVeyor and therefore causes unexpected errors. Use dynamic port assignment (using port 0) where possible, port 8121 otherwise.

Addtionally, add mock setup for IConnector.Dispose() where these mocks are used.

Author: JoostJM

src/Renci.SshNet.Tests/Classes/Channels/ChannelForwardedTcpipTest_Dispose_SessionIsConnectedAndChannelIsOpen.cs

@@ -67,6 +67,16 @@ public void CleanUp()
         private void Arrange()
         {
             var random = new Random();
+
+            _remoteEndpoint = new IPEndPoint(IPAddress.Loopback, 0);
+
+            _remoteListener = new AsyncSocketListener(_remoteEndpoint);
+            _remoteListener.Connected += socket => _connectedRegister.Add(socket);
+            _remoteListener.Disconnected += socket => _disconnectedRegister.Add(socket);
+            _remoteListener.Start();
+
+            _remoteEndpoint.Port = ((IPEndPoint)_remoteListener.ListenerEndPoint).Port;
+
             _localChannelNumber = (uint) random.Next(0, int.MaxValue);
             _localWindowSize = (uint) random.Next(2000, 3000);
             _localPacketSize = (uint) random.Next(1000, 2000);
@@ -80,8 +90,6 @@ private void Arrange()
             _disconnectedRegister = new List<Socket>();
             _connectionInfoTimeout = TimeSpan.FromSeconds(5);
 
-            _remoteEndpoint = new IPEndPoint(IPAddress.Loopback, 8122);
-
             _sessionMock = new Mock<ISession>(MockBehavior.Strict);
             _connectionInfoMock = new Mock<ISshConnectionInfo>(MockBehavior.Strict);
             _forwardedPortMock = new Mock<IForwardedPort>(MockBehavior.Strict);
@@ -124,11 +132,6 @@ private void Arrange()
                         })
                         .Returns(WaitResult.Success);
 
-            _remoteListener = new AsyncSocketListener(_remoteEndpoint);
-            _remoteListener.Connected += socket => _connectedRegister.Add(socket);
-            _remoteListener.Disconnected += socket => _disconnectedRegister.Add(socket);
-            _remoteListener.Start();
-
             _channel = new ChannelForwardedTcpip(
                 _sessionMock.Object,
                 _localChannelNumber,

src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_ConnectionToProxyRefused.cs

@@ -28,7 +28,7 @@ protected override void SetupData()
                                                  "user",
                                                  ProxyTypes.Http,
                                                  IPAddress.Loopback.ToString(),
-                                                 8122,
+                                                 8121,
                                                  "proxyUser",
                                                  "proxyPwd",
                                                  new KeyboardInteractiveAuthenticationMethod("user"));

src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_TimeoutConnectingToProxy.cs

@@ -31,7 +31,7 @@ protected override void SetupData()
                                                  "user",
                                                  ProxyTypes.Http,
                                                  IPAddress.Loopback.ToString(),
-                                                 8122,
+                                                 8121,
                                                  "proxyUser",
                                                  "proxyPwd",
                                                  new KeyboardInteractiveAuthenticationMethod("user"));

src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ConnectionClosedByServer_NoDataSentByServer.cs

@@ -50,7 +50,7 @@ protected void Arrange()
         {
             _clientVersion = "\uD55C";
             _timeout = TimeSpan.FromSeconds(5);
-            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122);
+            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 0);
             _dataReceivedByServer = new List<byte>();
 
             _server = new AsyncSocketListener(_serverEndPoint);
@@ -62,6 +62,8 @@ protected void Arrange()
                 };
             _server.Disconnected += (socket) => _clientDisconnected = true;
 
+            _serverEndPoint.Port = ((IPEndPoint)_server.ListenerEndPoint).Port;
+
             _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
             _client.Connect(_serverEndPoint);
 

src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseContainsNullCharacter.cs

@@ -53,7 +53,7 @@ protected void Arrange()
         {
             _clientVersion = "SSH-2.0-Renci.SshNet.SshClient.0.0.1";
             _timeout = TimeSpan.FromSeconds(5);
-            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122);
+            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 0);
             _dataReceivedByServer = new List<byte>();
             _serverIdentification = Encoding.UTF8.GetBytes("\uD55C!\0\uD55CSSH -2.0-Renci.SshNet.SshClient.0.0.1");
 
@@ -65,6 +65,8 @@ protected void Arrange()
                     _dataReceivedByServer.AddRange(bytes);
                 };
             _server.Disconnected += (socket) => _clientDisconnected = true;
+            
+            _serverEndPoint.Port = ((IPEndPoint)_server.ListenerEndPoint).Port;
 
             _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
             _client.Connect(_serverEndPoint);

src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseInvalid_SshIdentificationOnlyContainsProtocolVersion.cs

@@ -53,7 +53,7 @@ protected void Arrange()
         {
             _clientVersion = "SSH-2.0-Renci.SshNet.SshClient.0.0.1";
             _timeout = TimeSpan.FromSeconds(5);
-            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122);
+            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 0);
             _dataReceivedByServer = new List<byte>();
             _serverIdentification = Encoding.UTF8.GetBytes("SSH-2.0\r\n");
 
@@ -66,6 +66,8 @@ protected void Arrange()
                     socket.Shutdown(SocketShutdown.Send);
                 };
             _server.Disconnected += (socket) => _clientDisconnected = true;
+            
+            _serverEndPoint.Port = ((IPEndPoint)_server.ListenerEndPoint).Port;
 
             _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
             _client.Connect(_serverEndPoint);

src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_Comments.cs

@@ -53,7 +53,7 @@ protected void Arrange()
         {
             _clientVersion = "SSH-2.0-Renci.SshNet.SshClient.0.0.1";
             _timeout = TimeSpan.FromSeconds(5);
-            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122);
+            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 0);
             _dataReceivedByServer = new List<byte>();
             _serverIdentification = Encoding.UTF8.GetBytes("\r\nWelcome stranger!\r\n\r\nSSH-ABC2.0-OurSSHAppliance-1.4.7 Use at own risk.\uD55C\r\n!");
 
@@ -66,6 +66,8 @@ protected void Arrange()
                     socket.Shutdown(SocketShutdown.Send);
                 };
             _server.Disconnected += (socket) => _clientDisconnected = true;
+            
+            _serverEndPoint.Port = ((IPEndPoint)_server.ListenerEndPoint).Port;
 
             _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
             _client.Connect(_serverEndPoint);

src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_NoComments.cs

@@ -53,7 +53,7 @@ protected void Arrange()
         {
             _clientVersion = "SSH-2.0-Renci.SshNet.SshClient.0.0.1";
             _timeout = TimeSpan.FromSeconds(5);
-            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122);
+            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 0);
             _dataReceivedByServer = new List<byte>();
             _serverIdentification = Encoding.UTF8.GetBytes("Welcome stranger!\r\n\r\nSSH-Zero-OurSSHAppliance\r\n!");
 
@@ -66,6 +66,8 @@ protected void Arrange()
                     socket.Shutdown(SocketShutdown.Send);
                 };
             _server.Disconnected += (socket) => _clientDisconnected = true;
+            
+            _serverEndPoint.Port = ((IPEndPoint)_server.ListenerEndPoint).Port;
 
             _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
             _client.Connect(_serverEndPoint);

src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_TerminatedByLineFeedWithoutCarriageReturn.cs

@@ -53,7 +53,7 @@ protected void Arrange()
         {
             _clientVersion = "SSH-2.0-Renci.SshNet.SshClient.0.0.1";
             _timeout = TimeSpan.FromSeconds(5);
-            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122);
+            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 0);
             _dataReceivedByServer = new List<byte>();
             _serverIdentification = Encoding.UTF8.GetBytes("Welcome stranger!\n\nSSH-Zero-OurSSHAppliance\n\0");
 
@@ -67,6 +67,8 @@ protected void Arrange()
             };
             _server.Disconnected += (socket) => _clientDisconnected = true;
 
+            _serverEndPoint.Port = ((IPEndPoint)_server.ListenerEndPoint).Port;
+
             _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
             _client.Connect(_serverEndPoint);
 

src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_TimeoutReadingIdentificationString.cs

@@ -51,7 +51,7 @@ protected void Arrange()
         {
             _clientVersion = "SSH-2.0-Renci.SshNet.SshClient.0.0.1";
             _timeout = TimeSpan.FromMilliseconds(200);
-            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122);
+            _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 0);
             _dataReceivedByServer = new List<byte>();
             _clientDisconnected = false;
 
@@ -63,6 +63,8 @@ protected void Arrange()
                     socket.Send(Encoding.UTF8.GetBytes("Welcome!\r\n"));
                 };
             _server.Disconnected += (socket) => _clientDisconnected = true;
+            
+            _serverEndPoint.Port = ((IPEndPoint)_server.ListenerEndPoint).Port;
 
             _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp);
             _client.Connect(_serverEndPoint);