fix: Implement custom schema for config.affinity.nodeSelector (#752)

* fix: Fixed wrong schema for `config.affinity.nodeSelector`

* changelog

* Update CHANGELOG.md

Co-authored-by: Techassi <git@techassi.dev>

* Add docs on stackable_node_selector_schema

* Rename stackable_node_selector_schema -> optional_stackable_node_selector_schema

* USe #[schemars(deny_unknown_fields)]

* improve wording

* typo

* changelog

* doccomment -> normal comment

---------

Co-authored-by: Techassi <git@techassi.dev>

Author: sbernauer

crates/stackable-operator/CHANGELOG.md

@@ -8,6 +8,11 @@ All notable changes to this project will be documented in this file.
 
 - Implement `PartialEq` for most _Snafu_ Error enums ([#757]).
 
+## Fixed
+
+- Fix wrong schema (and thus CRD) for `config.affinity.nodeSelector` ([#752]).
+
+[#752]: https://github.com/stackabletech/operator-rs/pull/752
 [#757]: https://github.com/stackabletech/operator-rs/pull/757
 
 ## [0.65.0] - 2024-03-25

crates/stackable-operator/src/commons/affinity.rs

@@ -42,8 +42,18 @@ pub struct StackableAffinity {
     pub node_selector: Option<StackableNodeSelector>,
 }
 
+// We can not simply use [`BTreeMap<String, String>`] in [`StackableAffinity`], as the fields need to be [`Atomic`].
+// We can not mark it as [`Atomic`], as [`crate::config::fragment::FromFragment`] is already implemented for
+// [`BTreeMap<String, String>`].
+//
+// We `#[serde(flatten)]` the contained [`BTreeMap<String, String>`], so `serde_yaml` can deserialize everything as
+// expected.
+// FIXME: The generated JsonSchema will be wrong, so until https://github.com/GREsau/schemars/issues/259 is fixed, we
+// need to use `#[schemars(deny_unknown_fields)]`.
+// See https://github.com/stackabletech/operator-rs/pull/752#issuecomment-2017630433 for details.
 #[derive(Clone, Debug, Eq, Deserialize, JsonSchema, PartialEq, Serialize)]
 #[serde(rename_all = "camelCase")]
+#[schemars(deny_unknown_fields)]
 pub struct StackableNodeSelector {
     #[serde(flatten)]
     pub node_selector: BTreeMap<String, String>,