Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Volta support #17

Closed
chrisbbreuer opened this issue May 12, 2022 · 4 comments
Closed

Proper Volta support #17

chrisbbreuer opened this issue May 12, 2022 · 4 comments
Labels
blocked Temporarily blocked due to provided issue. enhancement New feature or request

Comments

@chrisbbreuer
Copy link
Member

chrisbbreuer commented May 12, 2022

It seems like it could be a great setup once this is merged volta-cli/rfcs#46

@chrisbbreuer chrisbbreuer added the enhancement New feature or request label May 12, 2022
@chrisbbreuer
Copy link
Member Author

At that point, let's also improve our actions where possible. https://github.com/volta-cli/action

@chrisbbreuer chrisbbreuer added the blocked Temporarily blocked due to provided issue. label Jun 13, 2022
@chrisbbreuer
Copy link
Member Author

There is a good chance that we may just develop our own package manager if I can't find a better solution than what we have right now. Certainly, no priority, but I will revisit this in a few weeks and then see where we go 😊

@chrisbbreuer
Copy link
Member Author

chrisbbreuer commented Oct 5, 2022

Currently, our implementation will be a custom shell script that checks for whether node & pnpm is installed. In case it is not, node is then managed via fnm and pnpm is activated via corepack.

I don't think we would need Volta anymore unless our script turns out unstable for the masses—which it shouldn't because corepack and fnm are pretty well-tested (even though corepack being experimental still)

@chrisbbreuer
Copy link
Member Author

We went with a custom script and pnpm/fnm as the node manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Temporarily blocked due to provided issue. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant