Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing on Windows #104

Open
varad64 opened this issue Jan 27, 2023 · 9 comments
Open

Build failing on Windows #104

varad64 opened this issue Jan 27, 2023 · 9 comments

Comments

@varad64
Copy link

varad64 commented Jan 27, 2023

Hello, I'm new to the project and while running the ./mvnw compile quarkus:dev maven command on Windows 10, the test testEcho() fails when the assertion seems to be satisfied with the same values. Does the assertion want the values to be different? I'm confused.

Please find below the error log:

2023-01-27 22:48:48,036 ERROR [io.qua.test] (Test runner thread) ==================== TEST REPORT #1 ====================
2023-01-27 22:48:48,041 ERROR [io.qua.test] (Test runner thread) Test StarfixTest#testEcho() failed
: org.opentest4j.AssertionFailedError: Echo Random String ==> expected: <This is some random String that I want to Echo

but was: <This is some random String that I want to Echo

    at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
    at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
    at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
    at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1152)
    at dev.starfix.StarfixTest.testEcho(StarfixTest.java:43)

Thanks!

@varad64
Copy link
Author

varad64 commented Jan 30, 2023

Update:

Tried it on a Linux machine using a VM and the test passes.

I believe the test fails on Windows as whitespace isn't being recognized. I tested the testEcho() method passing in trimmed versions of the strings to the assertEquals method and the test passes.

Please find the log below:

All 4 tests are passing (0 skipped), 4 tests were run in 2953ms. Tests completed at 14:33:11.
Press [space] to restart, [e] to edit command line args (currently ''), [r] to re-run, [o] Toggle test output, [h] for more options>
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50.032 s
[INFO] Finished at: 2023-01-30T14:33:26+05:30
[INFO] ------------------------------------------------------------------------

@fahad-israr
Copy link
Collaborator

Strange, this was working fine on gh-actions on a win64 machine. All the past builds are successful (Look at win64 build on https://github.com/starfixdev/starfix/actions).

@varad64
Copy link
Author

varad64 commented Jan 30, 2023

Strange, this was working fine on gh-actions on a win64 machine. All the past builds are successful (Look at win64 build on https://github.com/starfixdev/starfix/actions).

Yeah, that is odd. Previous builds had no problems

@fahad-israr
Copy link
Collaborator

Rename Issue to Build Failing on Windows and add rest details in the description.

@varad64 varad64 changed the title Test testEcho() in StarfixTest failing Build failing on Windows Feb 6, 2023
@Kshitiz-Mhto
Copy link

Kshitiz-Mhto commented Feb 14, 2023

hello, @varad64. i have tested the testcases in windows server 2019 and 2022 / latest using github action, it is working fine. i am not able to reproduce the errors.

@fahad-israr
Copy link
Collaborator

fahad-israr commented Feb 14, 2023

@Kshitiz-Mhto ref this : https://github.com/starfixdev/starfix/actions/runs/4097448503/jobs/7065829580
Latest run on gh-action .

@Kshitiz-Mhto
Copy link

@fahad-israr i have fixed the testEcho() test failing on windows, further i am working in command mvn package -Dnative for building native-image

@fahad-israr
Copy link
Collaborator

Great @Kshitiz-Mhto .
Link your PR too with the issue.

@fahad-israr
Copy link
Collaborator

Logging a strange event : Build did not fail when i created a PR #122. gh-actions workflow logs here: https://github.com/starfixdev/starfix/actions/runs/4239906148/jobs/7368393153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants