Should ResourceNotFound be mapped to a 404?

[indykoning]

When a

runway/src/Exceptions/ResourceNotFound.php

Line 5 in 27defcb

class ResourceNotFound extends \Exception

gets triggered it will cause a 500 error at the moment. Is this the intended behavior?

Laravel transforms their ModelNotFoundExceptions into NotFoundHttpException which makes more sense to me.
https://github.com/laravel/framework/blob/c9adca09a451f315aea8b92008021b12589d5206/src/Illuminate/Foundation/Exceptions/Handler.php#L668

We could emulate this behaviour using the render method: https://laravel.com/docs/12.x/errors#renderable-exceptions

public function render(Request $request): Response
{
    return app(\Illuminate\Foundation\Exceptions\Handler::class)->render($request, new NotFoundHttpException($e->getMessage(), $e));
}

Or alternatively https://github.com/laravel/framework/blob/c9adca09a451f315aea8b92008021b12589d5206/src/Illuminate/Foundation/Exceptions/Handler.php#L256 might work as well.

This way a 404 is rendered in case of a missing resource instead of a 500 error.

[duncanmcclean]

Out of curiosity, when are you running into the 500 error? Which route?

[BobWez98]

Indy is my colleague, my PR #755 is kinda related here. so mostly on the _ignition route