Optimize taxonomy <> collection queries (#376)

* wip

* pluck the slug

* use whereIn and wrap column

* test match driver

* test match driver

* support pgsql

* remove todo

* fix typo in variable name

* refactor

* Use config'd models

* Some more co-ercing

* 🍺

* update comment

* add case for postgress

* add test case for TermQueryBuilder where entries.driver is file

* cleanup dump

* We can't assume that the taxonomy is held in data now

---------

Co-authored-by: Bram de Leeuw <[email protected]>
Co-authored-by: Ryan Mitchell <[email protected]>

Author: TheBnl

src/Taxonomies/TermQueryBuilder.php

@@ -2,6 +2,8 @@
 
 namespace Statamic\Eloquent\Taxonomies;
 
+use Illuminate\Database\Query\Expression;
+use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Str;
 use Statamic\Contracts\Taxonomies\Term as TermContract;
 use Statamic\Facades\Blink;
@@ -222,13 +224,39 @@ private function applyCollectionAndTaxonomyWheres()
                             return [];
                         }
 
+                        // workaround to handle potential n+1 queries in the database
+                        // if/when Statamic core supports relationships in a meaningful way this should be removed
+                        if (config('statamic.eloquent-driver.entries.driver', 'file') == 'eloquent') {
+                            $entryClass = app('statamic.eloquent.entries.model');
+                            $termClass = app('statamic.eloquent.terms.model');
+
+                            $entriesTable = (new $entryClass)->getTable();
+                            $termsTable = (new $termClass)->getTable();
+
+                            return TermModel::where('taxonomy', $taxonomy)
+                                ->whereExists(function ($query) use ($entriesTable, $taxonomy, $termsTable) {
+                                    $wrappedColumn = $query->getGrammar()->wrap("{$termsTable}.slug");
+                                    $value = match ($query->getConnection()->getDriverName()) {
+                                        'sqlite' => new Expression($wrappedColumn),
+                                        'pgsql' => new Expression("to_jsonb({$wrappedColumn}::text)"),
+                                        default => DB::raw("concat('\"', {$wrappedColumn}, '\"')"),
+                                    };
+
+                                    $query->select(DB::raw(1))
+                                        ->from($entriesTable)
+                                        ->whereIn('collection', $this->collections)
+                                        ->whereJsonContains(Entry::query()->column($taxonomy->handle()), $value);
+                                })
+                                ->pluck('slug');
+                        }
+
                         return TermModel::where('taxonomy', $taxonomy)
                             ->select('slug')
                             ->get()
                             ->map(function ($term) use ($taxonomy) {
                                 return Entry::query()
                                     ->whereIn('collection', $this->collections)
-                                    ->whereJsonContains('data->'.$taxonomy, [$term->slug])
+                                    ->whereJsonContains($taxonomy->handle(), [$term->slug])
                                     ->count() > 0 ? $term->slug : null;
                             })
                             ->filter()

tests/Data/Taxonomies/TermQueryBuilderTest.php

@@ -207,6 +207,16 @@ public function terms_are_found_using_where_column()
         $this->assertEquals(['a', 'b', 'e'], $terms->map->slug()->all());
     }
 
+    #[Test]
+    public function it_filters_usage_in_collections_using_file_based_entries()
+    {
+        config()->set('statamic.eloquent-driver.entries.driver', 'file');
+        $this->it_filters_usage_in_collections();
+
+        // revert config to original
+        config()->set('statamic.eloquent-driver.entries.driver', 'eloquent');
+    }
+
     #[Test]
     public function it_filters_usage_in_collections()
     {