New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statping chart creates ingress, even if set to disabled #5

Open

florian-besser opened this issue Jan 19, 2024 · 0 comments

florian-besser commented Jan 19, 2024

The chart default values are: https://github.com/statping/charts/blob/main/charts/statping/values.yaml

ingress:
  # ingress.enabled -- Enable ingress
  enabled: false
  pathType: Prefix
  tls: false
  annotations: {}
  hostname: grafana.local
  secretName: statping-cert
  path: /
  secrets: []

Implying that by default no ingress would be created.

The chart implementation code creates one anyway tough: https://github.com/statping/charts/blob/main/charts/statping/templates/ingress.yaml

The enabled flag from the values.yaml is not queried in the code at all.

Can provide PR if OK.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment