refactor(e2e_appium): migrate to cloud reporting and enhance test assertions

- Replaced instances of LambdaTest reporting with Cloud reporting
- Assertion messages for clarity
- Updated test methods for toast handling

Author: glitchminer

test/e2e_appium/tests/test_backup_recovery_phrase.py

@@ -1,14 +1,14 @@
 import os
 import pytest
 
-from tests.base_test import BaseAppReadyTest, lambdatest_reporting
+from tests.base_test import BaseAppReadyTest, cloud_reporting
 from utils.screenshot import save_page_source
 from pages.app import App
 
 
 class TestBackupRecoveryPhrase(BaseAppReadyTest):
     @pytest.mark.critical
-    @lambdatest_reporting
+    @cloud_reporting
     def test_sign_out_from_settings(self):
         # BaseAppReadyTest ensures authenticated home
 
@@ -33,7 +33,7 @@ def test_sign_out_from_settings(self):
         [pytest.param(True, id="delete")],
     )
     @pytest.mark.smoke
-    @lambdatest_reporting
+    @cloud_reporting
     def test_backup_recovery_phrase_flow(self, remove_phrase):
         # BaseAppReadyTest ensures home; open Settings (left-nav preferred)
         opened = self.ctx.app.click_settings_left_nav()
@@ -72,10 +72,12 @@ def test_backup_recovery_phrase_flow(self, remove_phrase):
 
         # Verify toast appears and assert content-desc contains expected phrase (no fallbacks)
         app = App(self.driver)
-        assert app.is_toast_present(timeout=3), (
-            "Expected a toast to appear after backup completion"
+        keep_msg = app.wait_for_toast(
+            expected_substring="backed up your recovery phrase",
+            timeout=8,
+            stability=0.2,
         )
-        keep_msg = app.get_toast_content_desc(timeout=10) or ""
+        assert keep_msg, "Expected a toast to appear after backup completion"
         assert "backed up your recovery phrase" in keep_msg.lower()
 
         # Capture final state XML for reference
@@ -107,10 +109,12 @@ def test_backup_recovery_phrase_flow(self, remove_phrase):
             )
 
             # Verify toast after delete via content-desc substring (no fallbacks) BEFORE checking entry removal
-            assert app.is_toast_present(timeout=5), (
-                "Expected a toast to appear after deletion"
+            delete_msg = app.wait_for_toast(
+                expected_substring="recovery phrase permanently removed",
+                timeout=8,
+                stability=0.2,
             )
-            delete_msg = app.get_toast_content_desc(timeout=5) or ""
+            assert delete_msg, "Expected a toast to appear after deletion"
             assert "recovery phrase permanently removed" in delete_msg.lower()
 
             # After toast, verify entry removal

test/e2e_appium/tests/test_onboarding_flow.py

@@ -6,7 +6,7 @@
 """
 
 import pytest
-from tests.base_test import BaseTest, lambdatest_reporting
+from tests.base_test import BaseTest, cloud_reporting
 
 
 class TestOnboardingFlow(BaseTest):
@@ -15,7 +15,7 @@ class TestOnboardingFlow(BaseTest):
     @pytest.mark.smoke
     @pytest.mark.onboarding
     @pytest.mark.e2e
-    @lambdatest_reporting
+    @cloud_reporting
     @pytest.mark.onboarding_config(
         custom_display_name="E2E_TestUser",
         skip_analytics=True,
@@ -55,7 +55,7 @@ def test_onboarding_new_password_skip_analytics(self, onboarded_user):
         self.logger.info("Complete onboarding flow test with fixture passed!")
 
     @pytest.mark.onboarding
-    @lambdatest_reporting
+    @cloud_reporting
     @pytest.mark.onboarding_config(custom_display_name="E2E_TestUser")
     def test_onboarding_lands_on_main_app(self, onboarded_app):
         app = onboarded_app

test/e2e_appium/tests/test_onboarding_import_seed.py

@@ -1,6 +1,6 @@
 import pytest
 
-from tests.base_test import BaseTest, lambdatest_reporting
+from tests.base_test import BaseTest, cloud_reporting
 from pages.onboarding import (
     WelcomePage,
     AnalyticsPage,
@@ -17,13 +17,15 @@
 class TestOnboardingImportSeed(BaseTest):
     @pytest.mark.smoke
     @pytest.mark.onboarding
-    @lambdatest_reporting
+    @cloud_reporting
     def test_import_and_reimport_seed(self):
         seed_phrase = generate_seed_phrase()
         password = "TestPassword123!"
 
         welcome = WelcomePage(self.driver)
-        assert welcome.is_screen_displayed(timeout=30), "Welcome screen should be visible"
+        assert welcome.is_screen_displayed(timeout=30), (
+            "Welcome screen should be visible"
+        )
         assert welcome.click_create_profile(), "Failed to click Create profile"
 
         analytics = AnalyticsPage(self.driver)
@@ -32,18 +34,24 @@ def test_import_and_reimport_seed(self):
 
         create = CreateProfilePage(self.driver)
         assert create.is_screen_displayed(), "Create profile screen should be visible"
-        assert create.click_use_recovery_phrase(), "Failed to click Use a recovery phrase"
+        assert create.click_use_recovery_phrase(), (
+            "Failed to click Use a recovery phrase"
+        )
 
         seed_page = SeedPhraseInputPage(self.driver, flow_type="create")
-        assert seed_page.is_screen_displayed(), "Seed phrase input (create) should be visible"
+        assert seed_page.is_screen_displayed(), (
+            "Seed phrase input (create) should be visible"
+        )
         assert seed_page.import_seed_phrase(seed_phrase), "Failed to import seed phrase"
 
         password_page = PasswordPage(self.driver)
         assert password_page.is_screen_displayed(), "Password screen should be visible"
         assert password_page.create_password(password), "Failed to create password"
 
         splash = SplashScreen(self.driver)
-        assert splash.wait_for_loading_completion(timeout=60), "App did not finish loading"
+        assert splash.wait_for_loading_completion(timeout=60), (
+            "App did not finish loading"
+        )
 
         wallet_locators = WalletLocators()
 
@@ -54,7 +62,9 @@ def test_import_and_reimport_seed(self):
             base.safe_click(wallet_locators.ACCOUNT_1_BY_TEXT)
 
         # Read the header address displayed (truncated) via wallet header button
-        header_el = base.find_element_safe(wallet_locators.WALLET_HEADER_ADDRESS, timeout=10)
+        header_el = base.find_element_safe(
+            wallet_locators.WALLET_HEADER_ADDRESS, timeout=10
+        )
         assert header_el is not None, "Wallet header address button not found"
         header_desc = header_el.get_attribute("content-desc") or ""
         assert header_desc, "Header content-desc is empty"
@@ -66,22 +76,11 @@ def test_import_and_reimport_seed(self):
         )
 
         base_page = base
-        restarted = False
-        try:
-            restarted = base_page.restart_app("im.status.app")
-        except Exception:
-            restarted = False
-
-        if not restarted:
-            try:
-                self.driver.terminate_app("im.status.app")
-                self.driver.start_activity(
-                    "im.status.app", "org.qtproject.qt.android.bindings.QtActivity"
-                )
-            except Exception:
-                pass
+        restarted = base_page.restart_app()
+        assert restarted, "Failed to restart app before re-importing seed"
 
         from locators.onboarding.returning_login_locators import ReturningLoginLocators
+
         base = base_page
         rel = ReturningLoginLocators()
 
@@ -107,22 +106,38 @@ def nudge_user_selector() -> bool:
         assert opened, "Returning login user selector did not open"
 
         try:
-            base.safe_click(rel.CREATE_PROFILE_DROPDOWN_ITEM, timeout=10, max_attempts=2)
+            base.safe_click(
+                rel.CREATE_PROFILE_DROPDOWN_ITEM, timeout=10, max_attempts=2
+            )
         except Exception:
             el = base.find_element_safe(rel.CREATE_PROFILE_DROPDOWN_ITEM, timeout=3)
             assert el is not None, "Create profile item not found in dropdown"
-            assert base.gestures.element_tap(el), "Failed to tap Create profile dropdown item"
+            assert base.gestures.element_tap(el), (
+                "Failed to tap Create profile dropdown item"
+            )
 
         analytics = AnalyticsPage(self.driver)
-        assert analytics.is_screen_displayed(), "Analytics screen should be visible after choosing Create profile"
+        assert analytics.is_screen_displayed(), (
+            "Analytics screen should be visible after choosing Create profile"
+        )
         analytics.skip_analytics_sharing()
 
         create = CreateProfilePage(self.driver)
-        assert create.is_screen_displayed(), "Create profile screen should be visible (re-import path)"
-        assert create.click_use_recovery_phrase(), "Failed to click Use a recovery phrase (re-import path)"
+        assert create.is_screen_displayed(), (
+            "Create profile screen should be visible (re-import path)"
+        )
+        assert create.click_use_recovery_phrase(), (
+            "Failed to click Use a recovery phrase (re-import path)"
+        )
 
         seed_login = SeedPhraseInputPage(self.driver, flow_type="create")
-        assert seed_login.is_screen_displayed(), "Seed phrase screen should be visible (re-import path)"
-        assert seed_login.paste_seed_phrase_via_clipboard(seed_phrase), "Failed to paste seed phrase (re-import path)"
+        assert seed_login.is_screen_displayed(), (
+            "Seed phrase screen should be visible (re-import path)"
+        )
+        assert seed_login.paste_seed_phrase_via_clipboard(seed_phrase), (
+            "Failed to paste seed phrase (re-import path)"
+        )
 
-        assert not seed_login.is_continue_button_enabled(), "Continue should be disabled for already added seed phrase"
+        assert not seed_login.is_continue_button_enabled(), (
+            "Continue should be disabled for already added seed phrase"
+        )

test/e2e_appium/tests/test_saved_addresses.py

@@ -1,6 +1,6 @@
 import pytest
 
-from tests.base_test import BaseAppReadyTest, lambdatest_reporting
+from tests.base_test import BaseAppReadyTest, cloud_reporting
 from utils.generators import generate_ethereum_address, generate_account_name
 from pages.wallet.add_saved_address_modal import AddSavedAddressModal
 from pages.app import App
@@ -10,19 +10,24 @@
 
 
 class TestSavedAddresses(BaseAppReadyTest):
-
     @pytest.mark.wallet
     @pytest.mark.saved_addresses
     @pytest.mark.smoke
-    @lambdatest_reporting
+    @cloud_reporting
     def test_add_and_remove_saved_address(self):
-        assert self.ctx.app.safe_click(AppLocators().LEFT_NAV_WALLET, timeout=6), "Failed to open Wallet"
+        assert self.ctx.app.safe_click(AppLocators().LEFT_NAV_WALLET, timeout=6), (
+            "Failed to open Wallet"
+        )
         loc = SavedAddressesLocators()
-        assert self.ctx.app.safe_click(loc.WALLET_SAVED_ADDRESSES_BUTTON), "Failed to open Saved addresses from Wallet"
+        assert self.ctx.app.safe_click(loc.WALLET_SAVED_ADDRESSES_BUTTON), (
+            "Failed to open Saved addresses from Wallet"
+        )
         saved_addresses = SavedAddressesPage(self.driver)
         assert saved_addresses.is_loaded(timeout=10), "Saved Addresses view not opened"
-    
-        assert saved_addresses.open_add_saved_address_modal(), "Add Saved Address modal button not clickable"
+
+        assert saved_addresses.open_add_saved_address_modal(), (
+            "Add Saved Address modal button not clickable"
+        )
         modal = AddSavedAddressModal(self.driver)
         assert modal.is_displayed(timeout=10), "Add Saved Address modal did not appear"
 
@@ -33,15 +38,23 @@ def test_add_and_remove_saved_address(self):
         app = App(self.driver)
         assert app.is_toast_present(timeout=5), "Expected toast after saving address"
         toast_text = app.get_toast_content_desc(timeout=10) or ""
-        assert "successfully added" in toast_text.lower(), f"Unexpected toast: '{toast_text}'"
+        assert "successfully added" in toast_text.lower(), (
+            f"Unexpected toast: '{toast_text}'"
+        )
 
-        assert saved_addresses.is_entry_visible(name, timeout=30), f"Saved address '{name}' not visible in list"
+        assert saved_addresses.is_entry_visible(name, timeout=30), (
+            f"Saved address '{name}' not visible in list"
+        )
 
-        assert saved_addresses.open_details(name), "Failed to open saved address details"
-        assert saved_addresses.delete_saved_address_with_confirmation(name), "Failed to delete saved address via details menu"
+        assert saved_addresses.open_details(name), (
+            "Failed to open saved address details"
+        )
+        assert saved_addresses.delete_saved_address_with_confirmation(name), (
+            "Failed to delete saved address via details menu"
+        )
 
         app = App(self.driver)
         _ = app.get_toast_content_desc(timeout=5)
-        assert not saved_addresses.is_entry_visible(name, timeout=10), f"Saved address '{name}' still visible after deletion"
-
-
+        assert not saved_addresses.is_entry_visible(name, timeout=10), (
+            f"Saved address '{name}' still visible after deletion"
+        )

test/e2e_appium/tests/test_settings_password_change_password.py

@@ -2,14 +2,14 @@
 
 from constants import AppSections
 from locators.onboarding.wallet.wallet_locators import WalletLocators
-from tests.base_test import BaseAppReadyTest, lambdatest_reporting
+from tests.base_test import BaseAppReadyTest, cloud_reporting
 from utils.generators import generate_secure_password
 
 
 class TestSettingsPasswordChange(BaseAppReadyTest):
     @pytest.mark.critical
     @pytest.mark.smoke
-    @lambdatest_reporting
+    @cloud_reporting
     def test_change_password_and_login(self):
         assert self.ctx.app.click_settings_left_nav(), "Failed to open Settings"
         assert self.ctx.settings.is_loaded(), "Settings not detected"
@@ -25,9 +25,7 @@ def test_change_password_and_login(self):
             pass
 
         modal = password_settings.change_password(old_password, new_password)
-        assert modal and modal.is_displayed(), (
-            "Change password modal did not appear"
-        )
+        assert modal and modal.is_displayed(), "Change password modal did not appear"
         assert modal.complete_reencrypt_and_restart(), (
             "Failed to complete password re-encryption flow"
         )
@@ -38,6 +36,7 @@ def test_change_password_and_login(self):
         assert self.ctx.welcome_back.perform_login(new_password), (
             "Unable to authenticate after restart with the new password"
         )
+
         locators = WalletLocators()
         assert self.ctx.app.is_element_visible(
             locators.WALLET_FOOTER_SEND_BUTTON, timeout=15