feat(@desktop/externalLinks): Updated the calls made to launch external

links to new api based on the new behaviour

Author: Khushboo-dev-cpp

src/app/global/local_account_sensitive_settings.nim

@@ -36,7 +36,7 @@ const LAST_SECTION_CHAT = "LastSectionChat"
 const DEFAULT_ACTIVE_CHAT = ""
 const DEFAULT_SHOW_BROWSER_SELECTOR = true
 const LSS_KEY_OPEN_LINKS_IN_STATUS* = "openLinksInStatus"
-const DEFAULT_OPEN_LINKS_IN_STATUS = true
+const DEFAULT_OPEN_LINKS_IN_STATUS = false
 const LSS_KEY_SHOULD_SHOW_FAVORITES_BAR* = "shouldShowFavoritesBar"
 const DEFAULT_SHOULD_SHOW_FAVORITES_BAR = true
 const LSS_KEY_BROWSER_HOMEPAGE* = "browserHomepage"

storybook/pages/KeycardIntroPagePage.qml

@@ -30,8 +30,7 @@ Item {
             displayPromoBanner: ctrlDisplayPromo.checked
             onEmptyKeycardDetected: console.warn("!!! EMPTY DETECTED")
             onNotEmptyKeycardDetected: console.warn("!!! NOT EMPTY DETECTED")
-            onOpenLink: Qt.openUrlExternally(link)
-            onOpenLinkWithConfirmation: Qt.openUrlExternally(link)
+            onRequestOpenLink: Qt.openUrlExternally(link)
             onKeycardFactoryResetRequested: console.warn("!!! FACTORY RESET")
             onUnblockWithSeedphraseRequested: console.warn("!!! UNBLOCK WITH SEEDPHRASE")
             onUnblockWithPukRequested: console.warn("!!! UNBLOCK WITH PUK")

storybook/pages/PrivacyAndSecurityViewPage.qml

@@ -21,6 +21,7 @@ SplitView {
             SplitView.fillHeight: true
             contentWidth: parent.width
 
+            privacySectionTitle: "Privacy"
             whitelistedDomainsModel: ["example1.com", "example2.com", "example3.com"]
             isStatusNewsViaRSSEnabled: true
             isCentralizedMetricsEnabled: true

storybook/pages/ProfileSocialLinksPanelPage.qml

@@ -73,8 +73,8 @@ SplitView {
 
     Connections {
         target: Global
-        function onOpenLink(link) {
-            logs.logEvent("Global::openLink", ["link"], [link])
+        function onRequestOpenLink(link) {
+            logs.logEvent("Global::onRequestOpenLink", ["link"], [link])
         }
     }
 

storybook/qmlTests/tests/tst_BuyCryptoModal.qml

@@ -112,7 +112,7 @@ Item {
     SignalSpy {
         id: notificationSpy
         target: Global
-        signalName: "openLinkWithConfirmation"
+        signalName: "requestOpenLink"
     }
 
     TestCase {
@@ -250,7 +250,6 @@ Item {
             verify(controlUnderTest.rightButtons[0].loading)
             tryCompare(notificationSpy, "count", 1)
             compare(notificationSpy.signalArguments[0][0], "xxxx")
-            compare(notificationSpy.signalArguments[0][1], modelData.hostname)
             notificationSpy.clear()
 
             // popup should be closed
@@ -274,7 +273,6 @@ Item {
             verify(loadingIndicator.visible)
             tryCompare(notificationSpy, "count", 1)
             compare(notificationSpy.signalArguments[0][0], "xxxx")
-            compare(notificationSpy.signalArguments[0][1], modelData.hostname)
             notificationSpy.clear()
 
             // popup should be closed

storybook/qmlTests/tests/tst_SendSignModal.qml

@@ -129,7 +129,7 @@ Item {
     SignalSpy {
         id: signalSpyOpenLink
         target: Global
-        signalName: "openLinkWithConfirmation"
+        signalName: "requestOpenLink"
     }
 
     property SendSignModal controlUnderTest: null

ui/StatusQ/src/StatusQ/Components/StatusDraggableListItem.qml

@@ -81,7 +81,7 @@ import StatusQ.Core.Theme
                             font.pixelSize: Theme.primaryTextFontSize
                             font.weight: Font.Normal
                             text: draggableDelegate.asideText
-                            onClicked: Global.openLink(model.url)
+                            onClicked: Global.requestOpenLink(model.url)
                         },
                         StatusFlatRoundButton {
                             icon.name: "edit_pencil"

ui/app/AppLayouts/ActivityCenter/ActivityCenterLayout.qml

@@ -684,7 +684,7 @@ StatusSectionLayout {
         id: newsMessagePopup
 
         NewsMessagePopup {
-            onLinkClicked: Global.openLinkWithConfirmation(link, StatusQUtils.StringUtils.extractDomainFromLink(link));
+            onLinkClicked: Global.requestOpenLink(link)
         }
     }
 

ui/app/AppLayouts/Chat/views/ChatHeaderContentView.qml

@@ -329,7 +329,7 @@ RowLayout {
                     break;
                 }
             }
-            onLinkActivated: Global.openLink(link)
+            onLinkActivated: Global.requestOpenLink(link)
         }
     }
 

ui/app/AppLayouts/Communities/controls/Options.qml

@@ -113,8 +113,7 @@ ColumnLayout {
                 text: qsTr("Learn more about token-gating")
                 font.pixelSize: Theme.primaryTextFontSize
                 normalColor: linkColor
-                onClicked: Global.openLinkWithConfirmation(d.aboutPermissionsLink,
-                                                           StatusQUtils.StringUtils.extractDomainFromLink(d.aboutPermissionsLink))
+                onClicked: Global.requestOpenLink(d.aboutPermissionsLink)
             }
 
             StatusIcon {
@@ -127,8 +126,7 @@ ColumnLayout {
                     anchors.fill: parent
                     cursorShape: Qt.PointingHandCursor
 
-                    onClicked: Global.openLinkWithConfirmation(d.aboutPermissionsLink,
-                                                               StatusQUtils.StringUtils.extractDomainFromLink(d.aboutPermissionsLink))
+                    onClicked: Global.requestOpenLink(d.aboutPermissionsLink)
                 }
             }
         }
@@ -139,7 +137,7 @@ ColumnLayout {
         id: messageHistoryInfoPopupComponent
 
         EnableFullMessageHistoryPopup {
-            onAccepted: Global.openLinkWithConfirmation(d.aboutHistoryServiceLink, StatusQUtils.StringUtils.extractDomainFromLink(d.aboutHistoryServiceLink))
+            onAccepted: Global.requestOpenLink(d.aboutHistoryServiceLink)
             onClosed: destroy()
         }
     }