Skip to content

Commit 6670680

Browse files
authored
chore: address commit comments and use discrete uniform PRNG
PR-URL: #5313 Closes: #5303 Reviewed-by: Philipp Burckhardt <[email protected]> Reviewed-by: Karan Anand <[email protected]> Signed-off-by: Rishav Tarway <[email protected]>
1 parent a721643 commit 6670680

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

lib/node_modules/@stdlib/stats/base/dists/binomial/median/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ Returns the [median][median] of a [binomial][binomial-distribution] distribution
173173

174174
```c
175175
double out = stdlib_base_dists_binomial_median( 100, 0.1 );
176-
// returns 10
176+
// returns 10.0
177177
```
178178

179179
The function accepts the following arguments:

lib/node_modules/@stdlib/stats/base/dists/binomial/median/benchmark/benchmark.native.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,10 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var Int32Array = require( '@stdlib/array/int32' );
2625
var Float64Array = require( '@stdlib/array/float64' );
2726
var tryRequire = require( '@stdlib/utils/try-require' );
28-
var ceil = require( '@stdlib/math/base/special/ceil' );
29-
var randu = require( '@stdlib/random/base/randu' );
27+
var uniform = require( '@stdlib/random/base/uniform' );
28+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
3029
var isnan = require( '@stdlib/math/base/assert/is-nan' );
3130
var pkg = require( './../package.json' ).name;
3231

@@ -49,11 +48,11 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4948
var i;
5049

5150
len = 100;
52-
n = new Int32Array( len );
51+
n = new Float64Array( len );
5352
p = new Float64Array( len );
5453
for ( i = 0; i < len; i++ ) {
55-
n[ i ] = ceil( randu() * 100.0 );
56-
p[ i ] = randu();
54+
n[ i ] = discreteUniform( 1, 100 );
55+
p[ i ] = uniform( 0.0, 1.0 );
5756
}
5857

5958
b.tic();

lib/node_modules/@stdlib/stats/base/dists/binomial/median/src/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
*
3131
* @example
3232
* double y = stdlib_base_dists_binomial_median( 100, 0.1 );
33-
* // returns 10
33+
* // returns 10.0
3434
*/
3535
double stdlib_base_dists_binomial_median( const int32_t n, const double p ) {
3636
if (

0 commit comments

Comments
 (0)