Support Phanpy embeds

[wakest]

when using the fediverse client Phanpy, they have their own embed code so when pasting from there you could style it potentially the same as when copied from the Mastodon web front end.

or maybe it makes more sense to get Phanpy to show an option to copy the normal Mastodon embed code

either way its confusing rn cause I use Phanpy as my client and went to copy the embed code from a post and it took me a while to figure out why it wasn't working with your plugin

[stefanbohacek]

@wakest That is very interesting, I'll look into it!

Thank you for opening an issue for this!

[stefanbohacek]

@cheeaun Would you be interested in adding a class to the blockquote element that would help identify a Phanpy embed?

[cheeaun]

@stefanbohacek wondering, what would be a good class name?

[stefanbohacek]

@cheeaun One of the two hard problems in computer science!

Mastodon uses mastodon-embed, so perhaps phanpy-embed will do?

[cheeaun]

@stefanbohacek phanpy-embed sounds kinda weird as it's bound to a client, imagine there's ivory-embed or ice-cubes-embed in the future 😂

Thinking if a generic, future-proof, classless option like data-fediverse-embed-url=[URL] would make more sense?

[stefanbohacek]

Fair point! Maybe you could do both the class and a data attribute? I think it makes sense to follow Mastodon's example and identify the source of the embed, plus also use something more generic.

[cheeaun]

Hmm, I try not to include classes as there's potential for clash. [data-]* is still the safest, I think.

Phanpy is also not Mastodon-only, as it can work with Pixelfed, *key, Hometown, GTS, etc, which means it doesn't seem right to use mastodon-embed. I'm also not sure how you're fetching the post for the non-Mastodon instances.

But I guess besides data-fediverse-embed-url, this plugin also need something like data-fediverse-server="mastodon" right? So that you can check which server software and apply specific logic for it?

[stefanbohacek]

Sorry, to clarify, by following Mastodon's example I meant you could include phanpy-embed to identify this element as an embed code retrieved via Phanpy, not to use the actual mastodon-embed class.

Either way, I do like your idea of including the name of the platform via additional data attribute, this might even be a good feature to request for Mastodon (and other platforms, when they support embeds)!

[cheeaun]

I gave this some thought and seems like data-fediverse-server="mastodon" is not quite feasible, at least from client-side, as it needs to query the domain (webfinger or node-info) to know what server software it's running on - which can be (or should be?) done from this plugin instead? 🤔

Anyway, I could add data-fediverse-embed-url. Or… even more generic (and shorter) data-fediverse-url?

[stefanbohacek]

Sure, that works! And I don' t think the platform is necessary if it takes an extra effort, I figured you might already have this information available. Not worth the extra request, for sure.

Looking at the documentation for the blockquote element, here's an example of using URL as a source of a quote.

<blockquote cite="https://datatracker.ietf.org/doc/html/rfc1149">
  <p>
    ....
  </p>
</blockquote>

What do you think about building upon this, maybe something like:

<blockquote cite="https://mastodon.social/@user/123456789" data-source="fediverse">
  <p>
    ....
  </p>
</blockquote>