Skip to content

Commit 3a7c971

Browse files
piyalbasuclaude
andcommitted
Fix e2e swap tests for new asset-row formatting
The blockaidScan swap tests asserted the asset row was visible via a loose getByText(/USDC/) / getByText(/XLM/) locator, then clicked the row's -balance testid. Now that the row's second line includes the asset code ("100 USDC"), the regex matches both the heading and the balance line, tripping Playwright strict mode. Assert visibility on the -balance testid the test already clicks, which is unambiguous and intention-revealing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent c966d72 commit 3a7c971

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

extension/e2e-tests/blockaidScan.malicious.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,12 +271,12 @@ test.describe("BlockAid Scan - Malicious States", () => {
271271
await expect(page.getByTestId("AppHeaderPageTitle")).toContainText(
272272
"Swap from",
273273
);
274-
await expect(page.getByText(/XLM/)).toBeVisible();
274+
await expect(page.getByTestId("XLM-balance")).toBeVisible();
275275
await page.getByTestId("XLM-balance").click();
276276

277277
await page.getByTestId("swap-dst-asset-tile").click({ force: true });
278278
await expect(page.getByText("Swap to")).toBeVisible();
279-
await expect(page.getByText(/USDC/)).toBeVisible();
279+
await expect(page.getByTestId("USDC-balance")).toBeVisible();
280280
await page.getByTestId("USDC-balance").click();
281281

282282
await expect(page.getByTestId("AppHeaderPageTitle")).toContainText("Swap");

extension/e2e-tests/blockaidScan.safe.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,12 +275,12 @@ test.describe("BlockAid Scan - Safe States (No Override)", () => {
275275
await expect(page.getByTestId("AppHeaderPageTitle")).toContainText(
276276
"Swap from",
277277
);
278-
await expect(page.getByText(/XLM/)).toBeVisible();
278+
await expect(page.getByTestId("XLM-balance")).toBeVisible();
279279
await page.getByTestId("XLM-balance").click();
280280

281281
await page.getByTestId("swap-dst-asset-tile").click({ force: true });
282282
await expect(page.getByText("Swap to")).toBeVisible();
283-
await expect(page.getByText(/USDC/)).toBeVisible();
283+
await expect(page.getByTestId("USDC-balance")).toBeVisible();
284284
await page.getByTestId("USDC-balance").click();
285285

286286
await expect(page.getByTestId("AppHeaderPageTitle")).toContainText("Swap");

extension/e2e-tests/blockaidScan.suspicious.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,12 @@ test.describe("BlockAid Scan - Suspicious States", () => {
259259
await expect(page.getByTestId("AppHeaderPageTitle")).toContainText(
260260
"Swap from",
261261
);
262-
await expect(page.getByText(/XLM/)).toBeVisible();
262+
await expect(page.getByTestId("XLM-balance")).toBeVisible();
263263
await page.getByTestId("XLM-balance").click();
264264

265265
await page.getByTestId("swap-dst-asset-tile").click({ force: true });
266266
await expect(page.getByText("Swap to")).toBeVisible();
267-
await expect(page.getByText(/USDC/)).toBeVisible();
267+
await expect(page.getByTestId("USDC-balance")).toBeVisible();
268268
await page.getByTestId("USDC-balance").click();
269269

270270
await expect(page.getByTestId("AppHeaderPageTitle")).toContainText("Swap");

extension/e2e-tests/blockaidScan.unable.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,13 @@ test.describe("BlockAid Scan - Unable to Scan States", () => {
284284
await expect(page.getByTestId("AppHeaderPageTitle")).toContainText(
285285
"Swap from",
286286
);
287-
await expect(page.getByText(/XLM/)).toBeVisible();
287+
await expect(page.getByTestId("XLM-balance")).toBeVisible();
288288
await page.getByTestId("XLM-balance").click();
289289

290290
// Select destination token (USDC)
291291
await page.getByTestId("swap-dst-asset-tile").click({ force: true });
292292
await expect(page.getByText("Swap to")).toBeVisible();
293-
await expect(page.getByText(/USDC/)).toBeVisible();
293+
await expect(page.getByTestId("USDC-balance")).toBeVisible();
294294
await page.getByTestId("USDC-balance").click();
295295

296296
// Wait to be back at amount step

0 commit comments

Comments
 (0)