Skip to content

Commit d4c969b

Browse files
piyalbasuclaude
andauthored
ci: fix create-release input (target_commitish -> commitish) (#2866)
actions/create-release@v1's input is `commitish`, not `target_commitish`, so the value was silently ignored ("Unexpected input(s) 'target_commitish'") and release tags were created against the repo default branch (master) instead of the built ref. This put 5.42.1-beta.1's tag on master's HEAD rather than the emergency-release commit it was built from. Use the correct key so beta/prod release tags point at the actual built commit. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 21dac28 commit d4c969b

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/submitBeta.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
github.event.inputs.version }}
130130
draft: false
131131
prerelease: true
132-
target_commitish: ${{ steps.checkout_sha.outputs.sha }}
132+
commitish: ${{ steps.checkout_sha.outputs.sha }}
133133
- name: Upload Release Asset
134134
id: upload-release-asset
135135
uses: actions/upload-release-asset@v1

.github/workflows/submitProduction.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
body: ${{ steps.package_version.outputs.version }}
103103
draft: false
104104
prerelease: false
105-
target_commitish: ${{ steps.checkout_sha.outputs.sha }}
105+
commitish: ${{ steps.checkout_sha.outputs.sha }}
106106
- name: Build for Firefox
107107
id: web-ext-build
108108
uses: kewisch/action-web-ext@fe10addf5d5e5ba6b78ffde720dd488a27d10e8c #v1

0 commit comments

Comments
 (0)