Skip to content

Commit 283bc7c

Browse files
authored
♻️ Simplify tests, run in same backend service (fastapi#152)
remove backend-tests
1 parent 8f9c2ba commit 283bc7c

10 files changed

+8
-69
lines changed

{{cookiecutter.project_slug}}/.env

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
COMPOSE_PATH_SEPARATOR=:
2-
COMPOSE_FILE=docker-compose.test.yml:docker-compose.shared.admin.yml:docker-compose.shared.base-images.yml:docker-compose.shared.depends.yml:docker-compose.shared.env.yml:docker-compose.dev.build.yml:docker-compose.dev.command.yml:docker-compose.dev.env.yml:docker-compose.dev.labels.yml:docker-compose.dev.networks.yml:docker-compose.dev.ports.yml:docker-compose.dev.volumes.yml
2+
COMPOSE_FILE=docker-compose.shared.admin.yml:docker-compose.shared.base-images.yml:docker-compose.shared.depends.yml:docker-compose.shared.env.yml:docker-compose.dev.build.yml:docker-compose.dev.command.yml:docker-compose.dev.env.yml:docker-compose.dev.labels.yml:docker-compose.dev.networks.yml:docker-compose.dev.ports.yml:docker-compose.dev.volumes.yml
33

44
DOMAIN=localhost
55
# DOMAIN=local.dockertoolbox.tiangolo.com

{{cookiecutter.project_slug}}/backend/app/tests-start.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ set -e
33

44
python /app/app/tests_pre_start.py
55

6-
pytest $* /app/app/tests/
6+
pytest "$@" /app/app/tests/

{{cookiecutter.project_slug}}/backend/tests.dockerfile

-34
This file was deleted.

{{cookiecutter.project_slug}}/docker-compose.dev.build.yml

-6
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,6 @@ services:
1212
dockerfile: celeryworker.dockerfile
1313
args:
1414
env: dev
15-
backend-tests:
16-
build:
17-
context: ./backend
18-
dockerfile: tests.dockerfile
19-
args:
20-
env: dev
2115
frontend:
2216
build:
2317
context: ./frontend

{{cookiecutter.project_slug}}/docker-compose.dev.env.yml

-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,3 @@ services:
99
- RUN=celery worker -A app.worker -l info -Q main-queue -c 1
1010
- JUPYTER=jupyter lab --ip=0.0.0.0 --allow-root --NotebookApp.custom_display_url=http://127.0.0.1:8888
1111
- SERVER_HOST=http://${DOMAIN}
12-
backend-tests:
13-
environment:
14-
- JUPYTER=jupyter lab --ip=0.0.0.0 --allow-root --NotebookApp.custom_display_url=http://127.0.0.1:8888
15-
- SERVER_HOST=http://${DOMAIN}

{{cookiecutter.project_slug}}/docker-compose.dev.volumes.yml

-3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,3 @@ services:
66
celeryworker:
77
volumes:
88
- ./backend/app:/app
9-
backend-tests:
10-
volumes:
11-
- ./backend/app:/app

{{cookiecutter.project_slug}}/docker-compose.shared.env.yml

+4
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,13 @@ services:
1111
environment:
1212
- SERVER_NAME=${DOMAIN}
1313
- SERVER_HOST=https://${DOMAIN}
14+
# Allow explicit env var override for tests
15+
- SMTP_HOST=${SMTP_HOST}
1416
celeryworker:
1517
env_file:
1618
- .env
1719
environment:
1820
- SERVER_NAME=${DOMAIN}
1921
- SERVER_HOST=https://${DOMAIN}
22+
# Allow explicit env var override for tests
23+
- SMTP_HOST=${SMTP_HOST}

{{cookiecutter.project_slug}}/docker-compose.test.yml

-16
This file was deleted.

{{cookiecutter.project_slug}}/scripts/test-local.sh

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ if [ $(uname -s) = "Linux" ]; then
99
fi
1010

1111
docker-compose \
12-
-f docker-compose.test.yml \
1312
-f docker-compose.shared.admin.yml \
1413
-f docker-compose.shared.base-images.yml \
1514
-f docker-compose.shared.depends.yml \

{{cookiecutter.project_slug}}/scripts/test.sh

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,16 @@
33
# Exit in case of error
44
set -e
55

6-
DOMAIN=backend \
6+
DOMAIN=backend SMTP_HOST="" \
77
docker-compose \
88
-f docker-compose.shared.base-images.yml \
99
-f docker-compose.shared.env.yml \
1010
-f docker-compose.shared.depends.yml \
1111
-f docker-compose.deploy.build.yml \
12-
-f docker-compose.test.yml \
1312
config > docker-stack.yml
1413

1514
docker-compose -f docker-stack.yml build
1615
docker-compose -f docker-stack.yml down -v --remove-orphans # Remove possibly previous broken stacks left hanging after an error
1716
docker-compose -f docker-stack.yml up -d
18-
docker-compose -f docker-stack.yml exec -T backend-tests /tests-start.sh "$@"
17+
docker-compose -f docker-stack.yml exec -T backend bash /app/tests-start.sh "$@"
1918
docker-compose -f docker-stack.yml down -v --remove-orphans

0 commit comments

Comments
 (0)