Skip to content

Commit 7c037c4

Browse files
test: Fix intermittent failure in rpc_net.py --v2transport
Make sure that v2 handshake is complete before comparing getpeerinfo outputs so that `transport_protocol_type` isn't stuck at 'detecting'. - on the python side, this is ensured by default `wait_for_handshake = True` inside `add_p2p_connection()`. - on the c++ side, add a wait_until statement till `transport_protocol_type = v2` so that v2 handshake is complete. Co-Authored-By: Martin Zumsande <[email protected]>
1 parent ba907f9 commit 7c037c4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/functional/rpc_net.py

+1
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ def test_getpeerinfo(self):
113113
self.nodes[0].setmocktime(no_version_peer_conntime)
114114
with self.nodes[0].wait_for_new_peer():
115115
no_version_peer = self.nodes[0].add_p2p_connection(P2PInterface(), send_version=False, wait_for_verack=False)
116+
self.wait_until(lambda: self.nodes[0].getpeerinfo()[no_version_peer_id]["transport_protocol_type"] == "v2")
116117
self.nodes[0].setmocktime(0)
117118
peer_info = self.nodes[0].getpeerinfo()[no_version_peer_id]
118119
peer_info.pop("addr")

0 commit comments

Comments
 (0)