Skip to content

Commit d5a2ba4

Browse files
committed
Merge bitcoin#31416: doc: Fix incorrect send RPC docs
fad83e7 doc: Fix incorrect send RPC docs (MarcoFalke) Pull request description: It would be good to have accurate RPC docs, so that humans and machines can read them and rely on them. This fixes one issue. ACKs for top commit: fjahr: utACK fad83e7 rkrux: tACK fad83e7 luke-jr: tACK fad83e7 Tree-SHA512: 65d0cc18a62ef44833621464d74b743d24ffe2b853596dce2c4f423df0495142d50387c02ba1b54f5ca77d4ddb083d55116a8ac92698aa6558762d841664911e
2 parents 9914e73 + fad83e7 commit d5a2ba4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/wallet/rpc/spend.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -1226,16 +1226,18 @@ RPCHelpMan send()
12261226
{"include_watching", RPCArg::Type::BOOL, RPCArg::DefaultHint{"true for watch-only wallets, otherwise false"}, "Also select inputs which are watch only.\n"
12271227
"Only solvable inputs can be used. Watch-only destinations are solvable if the public key and/or output script was imported,\n"
12281228
"e.g. with 'importpubkey' or 'importmulti' with the 'pubkeys' or 'desc' field."},
1229-
{"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically. A JSON array of JSON objects",
1229+
{"inputs", RPCArg::Type::ARR, RPCArg::Default{UniValue::VARR}, "Specify inputs instead of adding them automatically.",
12301230
{
1231+
{"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "", {
12311232
{"txid", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The transaction id"},
12321233
{"vout", RPCArg::Type::NUM, RPCArg::Optional::NO, "The output number"},
1233-
{"sequence", RPCArg::Type::NUM, RPCArg::Optional::NO, "The sequence number"},
1234+
{"sequence", RPCArg::Type::NUM, RPCArg::DefaultHint{"depends on the value of the 'replaceable' and 'locktime' arguments"}, "The sequence number"},
12341235
{"weight", RPCArg::Type::NUM, RPCArg::DefaultHint{"Calculated from wallet and solving data"}, "The maximum weight for this input, "
12351236
"including the weight of the outpoint and sequence number. "
12361237
"Note that signature sizes are not guaranteed to be consistent, "
12371238
"so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures."
12381239
"Remember to convert serialized sizes to weight units when necessary."},
1240+
}},
12391241
},
12401242
},
12411243
{"locktime", RPCArg::Type::NUM, RPCArg::Default{0}, "Raw locktime. Non-0 value also locktime-activates inputs"},

0 commit comments

Comments
 (0)