Skip to content

fix: [DEVOPS-298] Remove version and x64 platform specification from mysql docker-compose item #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix: [DEVOPS-298] Remove version and x64 platform specification from mysql docker-compose item #234

merged 2 commits into from
Jan 20, 2025

Conversation

jtakalai
Copy link
Contributor

also fix the config

@jtakalai jtakalai requested a review from teogeb January 13, 2025 13:07
teogeb
teogeb reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@teogeb teogeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thanks! 👍

@jtakalai
cleanup: remove commented-out code
73b52fa 
also add explicit version
@jtakalai jtakalai requested a review from teogeb January 20, 2025 10:07
@jtakalai jtakalai changed the title Remove version and x64 platform specification from mysql docker-compose item DEVOPS-298: Remove version and x64 platform specification from mysql docker-compose item Jan 20, 2025
@jtakalai jtakalai changed the title DEVOPS-298: Remove version and x64 platform specification from mysql docker-compose item fix [DEVOPS-298]: Remove version and x64 platform specification from mysql docker-compose item Jan 20, 2025
@jtakalai jtakalai changed the title fix [DEVOPS-298]: Remove version and x64 platform specification from mysql docker-compose item fix: [DEVOPS-298] Remove version and x64 platform specification from mysql docker-compose item Jan 20, 2025
@jtakalai jtakalai merged commit 2557e2a into master Jan 20, 2025
2 of 4 checks passed
@jtakalai jtakalai deleted the fix-mysql-on-arm branch January 20, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teogeb teogeb teogeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtakalai @teogeb