chore: refactor to enforce override usage (#3959)

Author: Jason3S

packages/client/src/Subscribables/StoreValue.ts

@@ -37,7 +37,7 @@ class StoreValueImpl<T> extends AbstractSubscribable<T> implements StoreValue<T>
         return;
     }
 
-    subscribe(s: SubscriberLike<T>) {
+    override subscribe(s: SubscriberLike<T>) {
         const dispose = super.subscribe(s);
         const sFn = toSubscriberFn(s);
         sFn(this._value);

packages/client/src/Subscribables/SubscribableView.ts

@@ -27,12 +27,12 @@ class ViewImpl<T> extends SubscribableImpl<T> implements SubscribableView<T> {
         return this._value === symbolNoValue ? undefined : this._value;
     }
 
-    protected notify(value: T): void {
+    protected override notify(value: T): void {
         this._value = value;
         super.notify(value);
     }
 
-    subscribe(s: SubscriberLike<T>) {
+    override subscribe(s: SubscriberLike<T>) {
         const dispose = super.subscribe(s);
         if (this._value !== symbolNoValue) {
             const sFn = toSubscriberFn(s);

packages/client/src/Subscribables/internal/EmitterImpl.ts

@@ -2,11 +2,11 @@ import type { SubscribableSubscriber } from '../Subscribables';
 import { AbstractSubscribable } from './AbstractSubscribable';
 
 export class EmitterImpl<T> extends AbstractSubscribable<T> implements SubscribableSubscriber<T> {
-    public notify(value: T) {
+    public override notify(value: T) {
         super.notify(value);
     }
 
-    public done() {
+    public override done() {
         super.done();
     }
 }

packages/client/src/Subscribables/internal/SubscribableImpl.ts

@@ -15,13 +15,13 @@ export class SubscribableImpl<T> extends AbstractSubscribable<T> {
         this._source = subscribe;
     }
 
-    protected _stop() {
+    protected override _stop() {
         super._stop();
         disposeOf(this._dispose);
         this._dispose = undefined;
     }
 
-    protected _start() {
+    protected override _start() {
         super._start();
         if (this._isRunning && !this._dispose) {
             this._dispose = subscribeTo(this._source, { notify: (v) => this.notify(v), done: () => this.done() });

packages/client/src/Subscribables/operators/delayUnsubscribe.ts

@@ -25,15 +25,15 @@ class SubscribableDelayedUnsubscribeImpl<T> extends SubscribableImpl<T> {
         this._handleTimeout = undefined;
     }
 
-    protected _tryToStop(): void {
+    protected override _tryToStop(): void {
         this.clearTimeout();
         this._handleTimeout = setTimeout(() => {
             if (this._hasSubscribers()) return;
             this._stop();
         }, this._timeout);
     }
 
-    protected done() {
+    protected override done() {
         this.clearTimeout();
         super.done();
     }

packages/client/src/actionMenu.mts

@@ -182,7 +182,7 @@ class ActionButtonItem implements vscode.QuickInputButton {
 
 class CommandButtonItem extends ActionButtonItem {
     constructor(
-        public iconPath: vscode.ThemeIcon,
+        public override iconPath: vscode.ThemeIcon,
         public command: vscode.Command,
     ) {
         super(new vscode.ThemeIcon('gear'), command.tooltip ?? command.title, commandFn(command));
@@ -218,7 +218,7 @@ class MenuItem implements ActionMenuItem {
 class CommandMenuItem extends MenuItem {
     constructor(
         readonly command: vscode.Command,
-        public description?: string,
+        public override description?: string,
     ) {
         super(command.title, description, commandFn(command));
     }

packages/client/src/repl/emitterToWriteStream.mts

@@ -220,12 +220,12 @@ class ReadableEmitter extends stream.Readable {
         });
     }
 
-    _read() {
+    override _read() {
         this.paused = false;
         this.pushBuffer();
     }
 
-    _destroy() {
+    override _destroy() {
         this.disposable.dispose();
     }
 

packages/client/src/settings/DictionaryHelper.mts

@@ -418,7 +418,7 @@ export class DictionaryTargetError extends Error {
     constructor(
         msg: string,
         readonly dictTarget: DictionaryTarget,
-        readonly cause: Error | unknown,
+        override readonly cause: Error | unknown,
     ) {
         super(msg);
     }
@@ -429,7 +429,7 @@ export class UnableToAddWordError extends DictionaryTargetError {
         msg: string,
         dictTarget: DictionaryTarget,
         readonly words: string | string[],
-        readonly cause: Error | unknown,
+        override readonly cause: Error | unknown,
     ) {
         super(msg, dictTarget, cause);
     }

tsconfig.base.json

@@ -11,6 +11,7 @@
         "esModuleInterop": true,
         "newLine": "LF",
         "noImplicitAny": true,
+        "noImplicitOverride": true,
         "noImplicitThis": true,
         "noUnusedLocals": true,
         "noUnusedParameters": true,