web: don't close pinned tab on ctrl+w #7805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
requested changes
Mar 28, 2025
Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
web/pinned-tab-close-shortcut
branch
from
a74a9e0 to
3c19363
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when triggering the "close active tab" shortcut (ctrl+w/command+w), pinned tabs are not closed. Key changes include:
- Refactoring the action handler for closing tabs to check for a pinned active tab.
- Preventing the closure of pinned tabs by conditionally skipping the closeActiveTab() call.
thecodrr
requested changes
Mar 29, 2025
thecodrr
requested changes
Apr 10, 2025
Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
web/pinned-tab-close-shortcut
branch
from
679497e to
67bedd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi [email protected]
Closes #7776