WIP review asset/directory/package view models management

Author: Kryptos-FR

sources/editor/Stride.Core.Assets.Editor/ViewModels/AssetCollectionViewModel.CopyPaste.cs

@@ -344,7 +344,7 @@ public static List<AssetViewModel> PasteAssetsIntoPackage(PackageViewModel packa
             var assetDirectory = project == null ?
                 package.GetOrCreateAssetDirectory(location) :
                 project.GetOrCreateProjectDirectory(location);
-            var assetViewModel = package.CreateAsset(asset, assetDirectory);
+            var assetViewModel = package.CreateAsset(asset, assetDirectory, true);
             viewModels.Add(assetViewModel);
         }
 

sources/editor/Stride.Core.Assets.Presentation/ViewModels/AssetViewModel.cs

@@ -57,6 +57,8 @@ protected AssetViewModel(ConstructorParameters parameters)
             PropertyGraph.Changed += AssetPropertyChanged;
             PropertyGraph.ItemChanged += AssetPropertyChanged;
         }
+        // Add to directory after asset node has been created, so that listener to directory changes can retrieve it
+        directory.AddAsset(this, parameters.CanUndoRedoCreation);
         Initializing = false;
     }
 

sources/editor/Stride.Core.Assets.Presentation/ViewModels/DirectoryBaseViewModel.cs

@@ -87,9 +87,19 @@ public DirectoryBaseViewModel GetOrCreateDirectory(string path)
         return result;
     }
 
-    internal void AddAsset(AssetViewModel asset)
+    internal void AddAsset(AssetViewModel asset, bool canUndoRedo)
     {
-        assets.Add(asset);
+        if (canUndoRedo)
+        {
+            assets.Add(asset);
+        }
+        else
+        {
+            using (SuspendNotificationForCollectionChange(nameof(Assets)))
+            {
+                assets.Add(asset);
+            }
+        }
     }
 
     internal void RemoveAsset(AssetViewModel asset)

sources/editor/Stride.Core.Assets.Presentation/ViewModels/PackageViewModel.cs

@@ -136,9 +136,7 @@ public void LoadPackageInformation(IProgressViewModel? progressVM, ref double pr
             {
                 directory = GetOrCreateAssetDirectory(url.GetFullDirectory());
             }
-            var assetViewModel = CreateAsset(asset, directory);
-            directory.AddAsset(assetViewModel);
-
+            CreateAsset(asset, directory, false);
             progress++;
         }
 
@@ -197,7 +195,7 @@ private static int ComparePackageContent(ViewModelBase x, ViewModelBase y)
     }
 
     // FIXME xplat-editor: most method here should be moved to an utility in the editor project (asset project should have minimum capability)
-    public AssetViewModel CreateAsset(AssetItem assetItem, DirectoryBaseViewModel directory, ILogger? logger = null)
+    public AssetViewModel CreateAsset(AssetItem assetItem, DirectoryBaseViewModel directory, bool canUndoRedoCreation, ILogger? logger = null)
     {
         AssetCollectionItemIdHelper.GenerateMissingItemIds(assetItem.Asset);
         Session.GraphContainer.InitializeAsset(assetItem, logger);
@@ -206,7 +204,7 @@ public AssetViewModel CreateAsset(AssetItem assetItem, DirectoryBaseViewModel di
         {
             assetViewModelType = assetViewModelType.MakeGenericType(assetItem.Asset.GetType());
         }
-        return (AssetViewModel)Activator.CreateInstance(assetViewModelType, new ConstructorParameters(assetItem, directory, false))!;
+        return (AssetViewModel)Activator.CreateInstance(assetViewModelType, new ConstructorParameters(assetItem, directory, canUndoRedoCreation))!;
     }
 
     private void FillRootAssetCollection()