fix(system): fix caching issue with value with different types

gregberge · gregberge · commit 4a6ded3c89e2 · 2021-11-05T11:28:05.000+01:00
diff --git a/packages/system/src/style.ts b/packages/system/src/style.ts
@@ -64,7 +64,7 @@ export const themeGetter = <T = any>({
       if (!string(value) && !num(value) && value !== true) {
         return res as CSSScalar
       }
-      const cacheKey = `${value}-${defaultValue}`
+      const cacheKey = `${typeof value}-${value}-${defaultValue}`
       const cache = getCache<CSSScalar>(props.theme, `__themeGetter${id}`)
       if (cache.has(cacheKey)) return cache.get(cacheKey)
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ export const themeGetter = <T = any>({`
`64`	`64`	`if (!string(value) && !num(value) && value !== true) {`
`65`	`65`	`return res as CSSScalar`
`66`	`66`	`}`
`67`		- const cacheKey = `${value}-${defaultValue}`
	`67`	+ const cacheKey = `${typeof value}-${value}-${defaultValue}`
`68`	`68`	const cache = getCache<CSSScalar>(props.theme, `__themeGetter${id}`)
`69`	`69`	`if (cache.has(cacheKey)) return cache.get(cacheKey)`
`70`	`70`