[WIP] Multizone discrete adjoints for turbomachinery #2317

oleburghardt · 2024-07-02T19:03:55Z

Continued by #2446.

Original Message

This is, for now, a brief note on @joshkellyjak 's and my WIP on a discrete adjoint functionality for multizone (multi-stage, multi-row) turbomachinery cases. We intend to realize everything through the native multizone discrete adjoint solver, though some turbo-specific problems need to be resolved.

This will, probably, involve further additions/corrections/cleanups around the mixing plane interface so that it is recorded properly. The current recording seems to still be not fully correct.

SU2_CFD/src/solvers/CEulerSolver.cpp

+
+  su2double gammaIn_BC = 0;
+  if (nDim == 3){
+    gammaIn_BC = FlowDir[2]; //atan(FlowDir[2]/FlowDir[0]);


oleburghardt · 2024-08-14T19:22:19Z

@joshkellyjak @pcarruscag Should I make some first commits for a "tag type / debug" recording to this branch? (This problem is the main motivation but technically it's quite unrelated.)

We need it here, but it might be better to merge it from a dedicated branch.

…l write restart files during runtime (there is a bug, potentially when clearing the tape).

joshkellyjak · 2024-08-15T13:10:41Z

@joshkellyjak @pcarruscag Should I make some first commits for a "tag type / debug" recording to this branch? (This problem is the main motivation but technically it's quite unrelated.)

We need it here, but it might be better to merge it from a dedicated branch.

Personally I would like this to selfishly enhance my understanding, but I don't think it should be merged when we complete the PR. Could be useful documentation for the website.

oleburghardt · 2024-08-15T21:39:34Z

Personally I would like this to selfishly enhance my understanding, but I don't think it should be merged when we complete the PR. Could be useful documentation for the website.

Well I think the functionality should be merged at some point. It might become too much for this PR(?). Let me just go ahead and create a dedicated branch for the tag tape. We could just use that branch as a helper then and prepare it for develop after this one is merged.

pcarruscag · 2024-08-15T21:43:48Z

Ah now I got the comment. I would keep adding the debug tape separate from fixing the turbo issues

…zation.hpp (to cover RealReverseTag).

Common/src/CConfig.cpp

…code/SU2 into feature_mz_adjoint_for_turbo

…eature_mz_adjoint_for_turbo

…code/SU2 into feature_mz_adjoint_for_turbo

…' into feature_mz_adjoint_for_turbo" This reverts commit 9f1b07c, reversing changes made to 4327942.

joshkellyjak · 2024-09-03T14:12:37Z

Reverting an accidental merge

…his is a temporary change to avoid false positives when a tag tape is used. They might be unnecessary anyway though.

…te adjoint solver.

…g mode finding :-))

This reverts commit 683de77. Working on the wrong branch.

…ture_mz_adjoint_for_turbo

…code/SU2 into feature_mz_adjoint_for_turbo

…into feature_mz_adjoint_for_turbo" This reverts commit 89c95ba, reversing changes made to c002911.

…_for_turbo

SU2_CFD/src/solvers/CEulerSolver.cpp

joshkellyjak added PR: draft changelog:fix labels Aug 9, 2024

github-advanced-security bot found potential problems Aug 9, 2024

View reviewed changes

SU2_CFD/src/solvers/CEulerSolver.cpp

su2double gammaIn_BC = 0;

if (nDim == 3){

gammaIn_BC = FlowDir[2]; //atan(FlowDir[2]/FlowDir[0]);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Throw error message in case the multizone discrete adjoint solver wil…

3801e4d

…l write restart files during runtime (there is a bug, potentially when clearing the tape).

Softcode indentifier/index.

0e5f95b

oleburghardt mentioned this pull request Aug 15, 2024

[WIP] Tag / debug tape recordings #2343

Closed

6 tasks

oleburghardt and others added 5 commits August 16, 2024 00:48

Add tag type option to build system.

dc38cc3

Add option to use RealReverseTag as AD type.

19a1a70

Temporarily adjust/hardcode type size for memory alignment in vectori…

36c922e

…zation.hpp (to cover RealReverseTag).

added turbo obj funcs

84e97f4

Merge branch 'develop' into feature_mz_adjoint_for_turbo

e68f844

github-advanced-security bot found potential problems Aug 29, 2024

View reviewed changes

Common/src/CConfig.cpp Fixed Show fixed Hide fixed

Common/src/CConfig.cpp Fixed Show fixed Hide fixed

Common/src/CConfig.cpp Fixed Show fixed Hide fixed

joshkellyjak and others added 8 commits August 29, 2024 18:25

thems the breaks

bb0831d

Merge branch 'feature_mz_adjoint_for_turbo' of https://github.com/su2…

4327942

…code/SU2 into feature_mz_adjoint_for_turbo

Merge branch 'develop' into feature_mz_adjoint_for_turbo

ae68274

Resource releasing

905f1e6

Merge branch 'feature_mz_adjoint_for_turbo' of https://github.com/su2…

da21602

…code/SU2 into feature_mz_adjoint_for_turbo

Merge remote-tracking branch 'upstream/feature_tag_debug_tape' into f…

9f1b07c

…eature_mz_adjoint_for_turbo

Merge branch 'feature_mz_adjoint_for_turbo' of https://github.com/su2…

54515e9

…code/SU2 into feature_mz_adjoint_for_turbo

Revert "Merge remote-tracking branch 'upstream/feature_tag_debug_tape…

c002911

…' into feature_mz_adjoint_for_turbo" This reverts commit 9f1b07c, reversing changes made to 4327942.

joshkellyjak and others added 5 commits September 4, 2024 10:19

formatting

5a9773c

Add config option and indicator for a debug discrete adjoint run.

6e65dd1

Add routines for setting tags to AD structure.

82f69e9

Add kinds of recording for tag tapes.

9de8e93

Comment out checks in AD structure whether an identifier is active. T…

57fbcea

…his is a temporary change to avoid false positives when a tag tape is used. They might be unnecessary anyway though.

oleburghardt and others added 13 commits September 24, 2024 17:54

Add first WIP version of the tag debug mode to the (multizone) discre…

3da17d8

…te adjoint solver.

Fix preaccumulation error in ComputeVorticityAndStrainMag (first debu…

b0e7c86

…g mode finding :-))

Merge branch 'develop' into feature_tag_debug_tape

688797a

Revert small change (will be added to CoDi soon).

8556c2a

Resolves tag errors in turbo mode

683de77

Revert "Resolves tag errors in turbo mode"

13ca3f5

This reverts commit 683de77. Working on the wrong branch.

Merge remote-tracking branch 'origin/feature_tag_debug_tape' into fea…

89c95ba

…ture_mz_adjoint_for_turbo

Merge branch 'feature_mz_adjoint_for_turbo' of https://github.com/su2…

e1a04fa

…code/SU2 into feature_mz_adjoint_for_turbo

Resolving tag errors

887e9e6

Merge branch 'feature_mz_adjoint_for_turbo' of https://github.com/su2…

08b7979

…code/SU2 into feature_mz_adjoint_for_turbo

Revert "Merge remote-tracking branch 'origin/feature_tag_debug_tape' …

e40f943

…into feature_mz_adjoint_for_turbo" This reverts commit 89c95ba, reversing changes made to c002911.

Resolved tag tape debugging errors

a284b6b

Merge remote-tracking branch 'origin/develop' into feature_mz_adjoint…

27f790f

…_for_turbo

github-advanced-security bot found potential problems Jan 9, 2025

View reviewed changes

joshkellyjak and others added 2 commits January 21, 2025 17:10

Merge branch 'develop' into feature_mz_adjoint_for_turbo

1e7472d

Merge branch 'develop' into feature_mz_adjoint_for_turbo

67c032c

oleburghardt mentioned this pull request Feb 11, 2025

Tape recording debug mode #2442

Merged

6 tasks

joshkellyjak mentioned this pull request Feb 18, 2025

[WIP] Multizone adjoints for turbomachinery #2446

Open

5 tasks

oleburghardt closed this Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Multizone discrete adjoints for turbomachinery #2317

[WIP] Multizone discrete adjoints for turbomachinery #2317

Uh oh!

oleburghardt commented Jul 2, 2024 •

edited

Loading

Uh oh!

Check notice

oleburghardt commented Aug 14, 2024 •

edited

Loading

Uh oh!

joshkellyjak commented Aug 15, 2024

Uh oh!

oleburghardt commented Aug 15, 2024

Uh oh!

pcarruscag commented Aug 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshkellyjak commented Sep 3, 2024

Uh oh!

Check notice

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[WIP] Multizone discrete adjoints for turbomachinery #2317

[WIP] Multizone discrete adjoints for turbomachinery #2317

Uh oh!

Conversation

oleburghardt commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Original Message

Uh oh!

Check notice

oleburghardt commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshkellyjak commented Aug 15, 2024

Uh oh!

oleburghardt commented Aug 15, 2024

Uh oh!

pcarruscag commented Aug 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshkellyjak commented Sep 3, 2024

Uh oh!

Check notice

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

oleburghardt commented Jul 2, 2024 •

edited

Loading

oleburghardt commented Aug 14, 2024 •

edited

Loading