Skip to content

Commit 055f26f

Browse files
committed
use output from create-release to set upload_url
1 parent 7f9f786 commit 055f26f

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

.github/workflows/release-cli.yaml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
name: Release CLI
22

3+
# on:
4+
# push:
5+
# tags:
6+
# - "v*"
7+
8+
# used only for testing
39
on:
410
push:
5-
tags:
6-
- "v*"
11+
branches: ['feat/better-upload-url']
712

813
jobs:
914
create-release:
@@ -24,6 +29,8 @@ jobs:
2429
TODO: Write release notes
2530
draft: false
2631
prerelease: false
32+
outputs:
33+
upload_url: ${{ steps.create_release.outputs.upload_url }}
2734

2835
build-linux:
2936
name: Release Artifacts on Linux
@@ -55,12 +62,10 @@ jobs:
5562
cargo build --release
5663
cd ./target/release && tar -czvf dbdev.tar.gz ./dbdev
5764
58-
- name: Get Upload Url
59-
run: echo UPLOAD_URL=$(curl --silent https://api.github.com/repos/${{ github.repository }}/releases/latest | jq .upload_url --raw-output) >> $GITHUB_ENV
60-
6165
- name: Upload Release Asset
6266
uses: actions/upload-release-asset@v1
6367
env:
68+
UPLOAD_URL: ${{ needs.create-release.outputs.upload_url }}
6469
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6570
with:
6671
upload_url: ${{ env.UPLOAD_URL }}
@@ -88,12 +93,10 @@ jobs:
8893
cargo build --release
8994
cd ./target/release && tar -czvf dbdev.tar.gz ./dbdev
9095
91-
- name: Get Upload Url
92-
run: echo UPLOAD_URL=$(curl --silent https://api.github.com/repos/${{ github.repository }}/releases/latest | jq .upload_url --raw-output) >> $GITHUB_ENV
93-
9496
- name: Upload Release Asset
9597
uses: actions/upload-release-asset@v1
9698
env:
99+
UPLOAD_URL: ${{ needs.create-release.outputs.upload_url }}
97100
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
98101
with:
99102
upload_url: ${{ env.UPLOAD_URL }}
@@ -121,15 +124,10 @@ jobs:
121124
cargo build --release
122125
cd ./target/release && Compress-Archive -Path ./dbdev.exe -Destination dbdev.zip
123126
124-
- name: Get Upload Url
125-
run: |
126-
$Json = Invoke-WebRequest -Uri https://api.github.com/repos/${{ github.repository }}/releases/latest | ConvertFrom-Json
127-
$UploadUrl = $Json.upload_url
128-
echo "UPLOAD_URL=$UploadUrl" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
129-
130127
- name: Upload Release Asset
131128
uses: actions/upload-release-asset@v1
132129
env:
130+
UPLOAD_URL: ${{ needs.create-release.outputs.upload_url }}
133131
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
134132
with:
135133
upload_url: ${{ env.UPLOAD_URL }}

0 commit comments

Comments
 (0)