Use getter instead of passing as argument

Author: surbhiia

instrumentation/httpurlconnection/library/src/main/java/io/opentelemetry/instrumentation/library/httpurlconnection/HttpUrlInstrumentation.java

@@ -41,6 +41,10 @@ public void addAttributesExtractor(AttributesExtractor<URLConnection, Integer> e
         additionalExtractors.add(extractor);
     }
 
+    public List<AttributesExtractor<URLConnection, Integer>> getAdditionalExtractors() {
+        return additionalExtractors;
+    }
+
     /**
      * Configures the HTTP request headers that will be captured as span attributes as described in
      * <a
@@ -132,7 +136,7 @@ public boolean emitExperimentalHttpClientMetrics() {
 
     @Override
     public void install(@NotNull InstallationContext ctx) {
-        HttpUrlConnectionSingletons.configure(this, ctx.getOpenTelemetry(), additionalExtractors);
+        HttpUrlConnectionSingletons.configure(this, ctx.getOpenTelemetry());
     }
 
     /**

instrumentation/httpurlconnection/library/src/main/java/io/opentelemetry/instrumentation/library/httpurlconnection/internal/HttpUrlConnectionSingletons.java

@@ -20,7 +20,6 @@
 import io.opentelemetry.instrumentation.api.semconv.http.HttpSpanStatusExtractor;
 import io.opentelemetry.instrumentation.library.httpurlconnection.HttpUrlInstrumentation;
 import java.net.URLConnection;
-import java.util.List;
 
 public final class HttpUrlConnectionSingletons {
 
@@ -30,9 +29,7 @@ public final class HttpUrlConnectionSingletons {
     private static OpenTelemetry openTelemetryInstance;
 
     public static void configure(
-            HttpUrlInstrumentation instrumentation,
-            OpenTelemetry openTelemetry,
-            List<AttributesExtractor<URLConnection, Integer>> additionalExtractors) {
+            HttpUrlInstrumentation instrumentation, OpenTelemetry openTelemetry) {
 
         HttpUrlHttpAttributesGetter httpAttributesGetter = new HttpUrlHttpAttributesGetter();
 
@@ -67,7 +64,8 @@ public static void configure(
                         .addAttributesExtractor(httpClientPeerServiceAttributesExtractor)
                         .addOperationMetrics(HttpClientMetrics.get());
 
-        for (AttributesExtractor<URLConnection, Integer> extractor : additionalExtractors) {
+        for (AttributesExtractor<URLConnection, Integer> extractor :
+                instrumentation.getAdditionalExtractors()) {
             builder.addAttributesExtractor(extractor);
         }
 

instrumentation/okhttp/okhttp-3.0/library/src/main/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/OkHttpInstrumentation.java

@@ -38,6 +38,10 @@ public void addAttributesExtractor(AttributesExtractor<Interceptor.Chain, Respon
         additionalExtractors.add(extractor);
     }
 
+    public List<AttributesExtractor<Interceptor.Chain, Response>> getAdditionalExtractors() {
+        return additionalExtractors;
+    }
+
     /**
      * Configures the HTTP request headers that will be captured as span attributes as described in
      * <a
@@ -133,6 +137,6 @@ public boolean emitExperimentalHttpClientMetrics() {
 
     @Override
     public void install(@NotNull InstallationContext ctx) {
-        OkHttp3Singletons.configure(this, ctx.getOpenTelemetry(), additionalExtractors);
+        OkHttp3Singletons.configure(this, ctx.getOpenTelemetry());
     }
 }

instrumentation/okhttp/okhttp-3.0/library/src/main/java/io/opentelemetry/instrumentation/library/okhttp/v3_0/internal/OkHttp3Singletons.java

@@ -19,7 +19,6 @@
 import io.opentelemetry.instrumentation.okhttp.v3_0.internal.OkHttpAttributesGetter;
 import io.opentelemetry.instrumentation.okhttp.v3_0.internal.OkHttpClientInstrumenterBuilderFactory;
 import io.opentelemetry.instrumentation.okhttp.v3_0.internal.TracingInterceptor;
-import java.util.List;
 import okhttp3.Interceptor;
 import okhttp3.Request;
 import okhttp3.Response;
@@ -34,9 +33,7 @@ public final class OkHttp3Singletons {
     public static Interceptor TRACING_INTERCEPTOR = NOOP_INTERCEPTOR;
 
     public static void configure(
-            OkHttpInstrumentation instrumentation,
-            OpenTelemetry openTelemetry,
-            List<AttributesExtractor<Interceptor.Chain, Response>> additionalExtractors) {
+            OkHttpInstrumentation instrumentation, OpenTelemetry openTelemetry) {
         DefaultHttpClientInstrumenterBuilder<Interceptor.Chain, Response> instrumenterBuilder =
                 OkHttpClientInstrumenterBuilderFactory.create(openTelemetry)
                         .setCapturedRequestHeaders(instrumentation.getCapturedRequestHeaders())
@@ -58,7 +55,8 @@ public static void configure(
                         .setEmitExperimentalHttpClientMetrics(
                                 instrumentation.emitExperimentalHttpClientMetrics());
 
-        for (AttributesExtractor<Interceptor.Chain, Response> extractor : additionalExtractors) {
+        for (AttributesExtractor<Interceptor.Chain, Response> extractor :
+                instrumentation.getAdditionalExtractors()) {
             instrumenterBuilder = instrumenterBuilder.addAttributesExtractor(extractor);
         }