Fix checking process for vat_eu_if

Added some tests

Author: leganz

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.3.1] - 2020-12-17
+### Fixed
+- Validation checking mechanism adapted to handle the vat checking flow correctly
 ## [0.3.0] - 2020-12-16
 ### Added
 - Support for vat_eu_if:field,compare_value

src/VatValidatorServiceProvider.php

@@ -85,7 +85,11 @@ public function boot()
             try {
                 $data = $validator->getData();
 
-                if (isset($data[$parameters[0]]) === false || $data[$parameters[0]] != $parameters[1]) {
+                if ($parameters[1] === 'true' || $parameters[1] === 'false') {
+                    $parameters[1] = $parameters[1] === 'true';
+                }
+
+                if (isset($data[$parameters[0]]) === false || $data[$parameters[0]] !== $parameters[1]) {
                     return true;
                 }
 
@@ -102,6 +106,10 @@ public function boot()
             try {
                 $data = $validator->getData();
 
+                if ($parameters[2] === 'true' || $parameters[2] === 'false') {
+                    $parameters[2] = $parameters[2] === 'true';
+                }
+
                 if (isset($data[$parameters[0]]) === false || isset($data[$parameters[1]]) === false) {
                     // Required fields does not exists in the provided input
                     return false;
@@ -113,7 +121,7 @@ public function boot()
                     return true;
                 }
 
-                if ($data[$parameters[1]] != $parameters[2]) {
+                if ($data[$parameters[1]] !== $parameters[2]) {
                     return true;
                 }
 

tests/Units/VatValidatorTest.php

@@ -209,4 +209,44 @@ public function testIfValidationExtentionsVatEuAddressAndIfFailsIfCountryIsNotFr
         // Test
         $this->assertFalse($validator->fails());
     }
+
+    public function testIfValidationExtentinsVatEuIfThrowsExeception():void
+    {
+
+        // Prepare
+        $data = [
+            'vatid' => 'XXX',
+            'company' => true,
+        ];
+
+        $rules = [
+            'vatid' => 'vat_eu_if:company,true',
+        ];
+
+        // Execute
+        $validator = Validator::make($data, $rules);
+
+        // Test
+        $this->assertTrue($validator->fails());
+    }
+
+    public function testIfValidationExtentinsVatEuIfWorksIfCompanyIsFalse():void
+    {
+
+        // Prepare
+        $data = [
+            'vatid' => 'XXX',
+            'company' => false,
+        ];
+
+        $rules = [
+            'vatid' => 'vat_eu_if:company,true',
+        ];
+
+        // Execute
+        $validator = Validator::make($data, $rules);
+
+        // Test
+        $this->assertFalse($validator->fails());
+    }
 }