Migration generates invalid code for $$props

[ginpei]

The migration guide says:

all properties: don’t destructure let props = $props();

But the migration tool npx sv migrate svelte-5 converts this code...

<script lang="ts">
  const allProps = $$props;
</script>

... to the code with destructure:

<script lang="ts">
  interface Props {
    [key: string]: any
  }

  let { ...props }: Props = $props();
  const allProps = props;
</script>

It's supposed to be:

  const allProp: Props = $props();

[ginpei]

This leads the "p has already been declared" issue (EMH333/esbuild-svelte#260) by the compiler issue (sveltejs/svelte#15375)

[paoloricciuti]

That issue is probably about esbuild rather than svelte (except probably we can loosen the validation around vars)...but this is perfectly valid code so adding extra code in the migration is really not useful imho. Gonna close this but thanks for reporting

[ginpei]

I thought destructure was prohibited but found I just misread it. Thanks for the quick response