vscode does not run eslint on .svelte files

[leon]

Describe the bug

Using vscode, the svelte rules are not getting run on .svelte files when navigating around in the code base.

It is because vscodes eslint plugin does not check .svelte files.

to get it working you need to explicitly tell vscode to also check .svelte files by adding

// .vscode/settings.json

// by adding "svelte" to this list it starts working
// not sure if we can append instead of redefining.
"eslint.validate": [
  "javascript",
  "typescript",
  "markdown",
  "svelte"
],

Don't know if the above is the best solve.
but if so the .vscode/settings.json should be added to the sv create template.

Reproduction

using sv to create a new project, and the add a new component with an #each block in it without the (mything.id) key

using vscode this should warn about you not having a key.
if I run

pnpm check

it will report that the key is missing.

Logs

System Info

System:
    OS: macOS 15.5
    CPU: (12) arm64 Apple M2 Max
    Memory: 105.02 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.16.0 - ~/.nvm/versions/node/v22.16.0/bin/node
    npm: 10.9.2 - ~/.nvm/versions/node/v22.16.0/bin/npm
    pnpm: 10.12.4 - ~/.nvm/versions/node/v22.16.0/bin/pnpm
    bun: 1.2.5 - ~/.bun/bin/bun
  Browsers:
    Chrome: 137.0.7151.120
    Edge: 138.0.3351.55
    Safari: 18.5
    Safari Technology Preview: 26.0
  npmPackages:
    svelte: ^5.0.0 => 5.34.8

Severity

annoyance

[manuel3108]

@baseballyama do you have an opinion on that? I wonder if the only way to tell that to eslint would be the vscode specific settings file. Is there potentially another way?

[baseballyama]

I think the only way is to add settings to .vscode/settings.json.
It would be nice if the ESLint VSCode extension could read eslint.config.js and notify us of any obviously missing file extensions.😅

How about generating a .vscode/settings.json as well when VSCode is selected as the editor in sv create command?

(Note: This is already mentioned in the eslint-plugin-svelte README.)
https://github.com/sveltejs/eslint-plugin-svelte?tab=readme-ov-file#editor-integrations

[manuel3108]

How about generating a .vscode/settings.json as well when VSCode is selected as the editor in sv create command?

what do you mean when vscode is selected? We don't have an editor prompt. Also when creating a new project personally i just run it from a command line not within any editor, so I currently have no clue if and how we could detect that.

Also just generating a .vscode/settings.json in all cases, does not seem correct to me. Sure, we could ask the user if we should generate that file for them, but since eslint is so common, im unsure if we should bother the users with such a question.

[baseballyama]

what do you mean when vscode is selected?

We can select ESLint and Prettier and more things with the sv create command, right? I meant being able to select VSCode as well at that time.

Also just generating a .vscode/settings.json in all cases, does not seem correct to me. Sure, we could ask the user if we should generate that file for them, but since eslint is so common, im unsure if we should bother the users with such a question.

If we select ESLint for a Svelte project, .vscode/settings.json is always necessary if user doesn't configure user level VSCode config, so I feel that generating .vscode/settings.json would at least do no harm.
Also, on a related note, when using a Svelte project, we need to use at least the Svelte extension, so it might be convenient to automatically generate .vscode/extensions.json to indicate the required extensions as well.

[jycouet]

generating .vscode/settings.json would at least do no harm

I'm not sure VIM users will agree ^^ (cursor user here :p)

---

When you use the terminal inside vscode, you have the env TERM_PROGRAM=vscode. But inside cursor, you have the same! So it's probably hard to auto detect things.

Maybe instead of a sub-question depending on selection, it could be a full addon ? IDE setup (or similar) ? I could also imagine some AI rules at some point! But the quesiton is: what IDE to support at start ?

[baseballyama]

I'm not sure VIM users will agree ^^ (cursor user here :p)

I suggested allowing users to select VSCode in the same way they can select ESLint or Prettier with the sv create command.
Vim users would not select VSCode, so .vscode/settings.json would not be generated for them.

VSCode forks like Cursor can be treated as VSCode. It’s simply a matter of how to display them in the TUI.

[manuel3108]

Ohh, now I understand, thanks. I'm still unsure if this is something I want to have in the cli. I will need to think about that, but i do understand the necessity.

[hyunbinseo]

No configuration will be needed on dbaeumer.vscode-eslint@3.0.20 and later.

• docs: update vs code eslint config eslint-plugin-svelte#1396 (comment)

[manuel3108]

Perfect, in that case, let's close this!