Skip to content

Commit e868f0a

Browse files
b49020daniel-thompson
authored andcommittedJul 27, 2021
kdb: Rename members of struct kdbtab_t
Remove redundant prefix "cmd_" from name of members in struct kdbtab_t for better readibility. Suggested-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Sumit Garg <sumit.garg@linaro.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20210712134620.276667-5-sumit.garg@linaro.org Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
1 parent 9a5db53 commit e868f0a

File tree

5 files changed

+252
-254
lines changed

5 files changed

+252
-254
lines changed
 

‎include/linux/kdb.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ typedef int (*kdb_func_t)(int, const char **);
6868

6969
/* The KDB shell command table */
7070
typedef struct _kdbtab {
71-
char *cmd_name; /* Command name */
72-
kdb_func_t cmd_func; /* Function to execute command */
73-
char *cmd_usage; /* Usage String for this command */
74-
char *cmd_help; /* Help message for this command */
75-
short cmd_minlen; /* Minimum legal # cmd chars required */
76-
kdb_cmdflags_t cmd_flags; /* Command behaviour flags */
71+
char *name; /* Command name */
72+
kdb_func_t func; /* Function to execute command */
73+
char *usage; /* Usage String for this command */
74+
char *help; /* Help message for this command */
75+
short minlen; /* Minimum legal # cmd chars required */
76+
kdb_cmdflags_t flags; /* Command behaviour flags */
7777
struct list_head list_node; /* Command list */
7878
} kdbtab_t;
7979

‎kernel/debug/kdb/kdb_bp.c

+36-36
Original file line numberDiff line numberDiff line change
@@ -523,51 +523,51 @@ static int kdb_ss(int argc, const char **argv)
523523
}
524524

525525
static kdbtab_t bptab[] = {
526-
{ .cmd_name = "bp",
527-
.cmd_func = kdb_bp,
528-
.cmd_usage = "[<vaddr>]",
529-
.cmd_help = "Set/Display breakpoints",
530-
.cmd_flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
526+
{ .name = "bp",
527+
.func = kdb_bp,
528+
.usage = "[<vaddr>]",
529+
.help = "Set/Display breakpoints",
530+
.flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
531531
},
532-
{ .cmd_name = "bl",
533-
.cmd_func = kdb_bp,
534-
.cmd_usage = "[<vaddr>]",
535-
.cmd_help = "Display breakpoints",
536-
.cmd_flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
532+
{ .name = "bl",
533+
.func = kdb_bp,
534+
.usage = "[<vaddr>]",
535+
.help = "Display breakpoints",
536+
.flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
537537
},
538-
{ .cmd_name = "bc",
539-
.cmd_func = kdb_bc,
540-
.cmd_usage = "<bpnum>",
541-
.cmd_help = "Clear Breakpoint",
542-
.cmd_flags = KDB_ENABLE_FLOW_CTRL,
538+
{ .name = "bc",
539+
.func = kdb_bc,
540+
.usage = "<bpnum>",
541+
.help = "Clear Breakpoint",
542+
.flags = KDB_ENABLE_FLOW_CTRL,
543543
},
544-
{ .cmd_name = "be",
545-
.cmd_func = kdb_bc,
546-
.cmd_usage = "<bpnum>",
547-
.cmd_help = "Enable Breakpoint",
548-
.cmd_flags = KDB_ENABLE_FLOW_CTRL,
544+
{ .name = "be",
545+
.func = kdb_bc,
546+
.usage = "<bpnum>",
547+
.help = "Enable Breakpoint",
548+
.flags = KDB_ENABLE_FLOW_CTRL,
549549
},
550-
{ .cmd_name = "bd",
551-
.cmd_func = kdb_bc,
552-
.cmd_usage = "<bpnum>",
553-
.cmd_help = "Disable Breakpoint",
554-
.cmd_flags = KDB_ENABLE_FLOW_CTRL,
550+
{ .name = "bd",
551+
.func = kdb_bc,
552+
.usage = "<bpnum>",
553+
.help = "Disable Breakpoint",
554+
.flags = KDB_ENABLE_FLOW_CTRL,
555555
},
556-
{ .cmd_name = "ss",
557-
.cmd_func = kdb_ss,
558-
.cmd_usage = "",
559-
.cmd_help = "Single Step",
560-
.cmd_minlen = 1,
561-
.cmd_flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
556+
{ .name = "ss",
557+
.func = kdb_ss,
558+
.usage = "",
559+
.help = "Single Step",
560+
.minlen = 1,
561+
.flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
562562
},
563563
};
564564

565565
static kdbtab_t bphcmd = {
566-
.cmd_name = "bph",
567-
.cmd_func = kdb_bp,
568-
.cmd_usage = "[<vaddr>]",
569-
.cmd_help = "[datar [length]|dataw [length]] Set hw brk",
570-
.cmd_flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
566+
.name = "bph",
567+
.func = kdb_bp,
568+
.usage = "[<vaddr>]",
569+
.help = "[datar [length]|dataw [length]] Set hw brk",
570+
.flags = KDB_ENABLE_FLOW_CTRL | KDB_REPEAT_NO_ARGS,
571571
};
572572

573573
/* Initialize the breakpoint table and register breakpoint commands. */

0 commit comments

Comments
 (0)
Please sign in to comment.