[lldb][windows] add NSDate and FoundationEssentials.Date dataformatters

Author: charles-zablit

lldb/source/Plugins/Language/ObjC/Cocoa.cpp

@@ -1256,22 +1256,28 @@ bool lldb_private::formatters::ObjCSELSummaryProvider(
 // this call gives the POSIX equivalent of the Cocoa epoch
 time_t lldb_private::formatters::GetOSXEpoch() {
   static time_t epoch = 0;
+#ifndef _AIX
   if (!epoch) {
-#if !defined(_WIN32) && !defined(_AIX)
+#ifndef _WIN32
     tzset();
+#endif
     tm tm_epoch;
     tm_epoch.tm_sec = 0;
-    tm_epoch.tm_hour = 0;
     tm_epoch.tm_min = 0;
-    tm_epoch.tm_mon = 0;
+    tm_epoch.tm_hour = 0;
     tm_epoch.tm_mday = 1;
+    tm_epoch.tm_mon = 0;
     tm_epoch.tm_year = 2001 - 1900;
     tm_epoch.tm_isdst = -1;
+#ifdef _WIN32
+    epoch = _mkgmtime(&tm_epoch);
+#else
     tm_epoch.tm_gmtoff = 0;
     tm_epoch.tm_zone = nullptr;
     epoch = timegm(&tm_epoch);
 #endif
   }
+#endif
   return epoch;
 }
 

lldb/source/Plugins/Language/Swift/FoundationValueTypes.cpp

@@ -37,6 +37,14 @@ bool lldb_private::formatters::swift::Date_SummaryProvider(
 
   ValueObjectSP time_sp(valobj.GetChildAtNamePath({g__time}));
 
+#ifdef _WIN32
+  static ConstString g__timeIntervalSinceReferenceDate(
+      "_timeIntervalSinceReferenceDate");
+  if (!time_sp)
+    time_sp = valobj.GetChildAtNamePath(
+        {g__timeIntervalSinceReferenceDate, "_value"});
+#endif
+
   if (!time_sp)
     return false;
 

lldb/source/Plugins/Language/Swift/SwiftLanguage.cpp

@@ -670,8 +670,16 @@ LoadFoundationValueTypesFormatters(lldb::TypeCategoryImplSP swift_category_sp) {
 
   lldb_private::formatters::AddCXXSummary(
       swift_category_sp, lldb_private::formatters::swift::Date_SummaryProvider,
-      "Foundation.Date summary provider", ConstString("Foundation.Date"),
+      "Foundation.Date summary provider",
+      ConstString("Foundation(Essentials)?\\.Date"),
+      TypeSummaryImpl::Flags(summary_flags).SetDontShowChildren(true), true);
+
+#ifdef _WIN32
+  lldb_private::formatters::AddCXXSummary(
+      swift_category_sp, lldb_private::formatters::swift::Date_SummaryProvider,
+      "Foundation.NSDate summary provider", ConstString("Foundation.NSDate"),
       TypeSummaryImpl::Flags(summary_flags).SetDontShowChildren(true));
+#endif
 
   lldb_private::formatters::AddCXXSummary(
       swift_category_sp,

lldb/test/API/functionalities/breakpoint/jit_loader_rtdyld_elf/Makefile

@@ -0,0 +1,14 @@
+CXX_SOURCES := jitbp.cpp
+
+include Makefile.rules
+
+# Build LLVM IR that lli will JIT.
+# Matches the commands from the shell test.
+jitbp.ll: jitbp.cpp
+	$(CXX) -g -S -emit-llvm --target=x86_64-unknown-unknown-elf \
+	      -o $@ $<
+
+all: jitbp.ll
+
+clean::
+	rm -f jitbp.ll

lldb/test/API/functionalities/breakpoint/jit_loader_rtdyld_elf/TestJitBreakpoint.py

@@ -0,0 +1,63 @@
+"""
+Test that pending breakpoints resolve for JITted code with MCJIT and RuntimeDyld.
+Converted from the original LLDB shell test.
+"""
+
+import lldb
+import os
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+class TestJitBreakpoint(TestBase):
+
+    def setUp(self):
+        TestBase.setUp(self)
+        # Makefile builds jitbp.ll for us
+        self.ll = self.getBuildArtifact("jitbp.ll")
+
+    @skipUnlessArch("x86_64")
+    @expectedFailureAll(oslist=["windows"])
+    def test_jit_breakpoints(self):
+        self.build()  # Runs the Makefile → produces jitbp.ll
+        self.do_test("--jit-kind=mcjit")
+        self.do_test("--jit-linker=rtdyld")
+
+    def do_test(self, jit_flag):
+        debugger = self.dbg
+        debugger.SetAsync(False)
+
+        # Equivalent to: settings set plugin.jit-loader.gdb.enable on
+        debugger.HandleCommand("settings set plugin.jit-loader.gdb.enable on")
+
+        # Create target for lli
+        lli_path = lldbutil.which("lli")
+        self.assertIsNotNone(lli_path, "Could not find lli executable")
+        target = debugger.CreateTarget(lli_path)
+        self.assertTrue(target.IsValid())
+
+        # Create pending breakpoint: b jitbp
+        bp = target.BreakpointCreateByName("jitbp")
+        self.assertTrue(bp.IsValid())
+        self.assertEqual(bp.GetNumLocations(), 0, "Expected pending breakpoint")
+
+        # Launch lli with JIT flag and compiled jitbp.ll
+        launch_info = target.GetLaunchInfo()
+        launch_info.SetArguments([jit_flag, self.ll], True)
+
+        error = lldb.SBError()
+        process = target.Launch(launch_info, error)
+        self.assertTrue(process.IsValid())
+        self.assertTrue(error.Success(), error.GetCString())
+
+        # Expect stop at JITted breakpoint
+        self.assertEqual(process.GetState(), lldb.eStateStopped)
+
+        # Validate call frame
+        thread = process.GetSelectedThread()
+        frame = thread.GetSelectedFrame()
+        self.assertIn("jitbp", frame.GetFunctionName())
+
+        # Breakpoint should now have resolved
+        self.assertGreaterEqual(bp.GetNumLocations(), 1,
+                                "Breakpoint must resolve after JIT loads code")

lldb/test/API/functionalities/breakpoint/jit_loader_rtdyld_elf/jitbp.cpp

@@ -0,0 +1,2 @@
+int jitbp() { return 0; }
+int main() { return jitbp(); }

lldb/test/API/functionalities/data-formatter/swift/date/Makefile

@@ -0,0 +1,3 @@
+SWIFT_SOURCES := main.swift
+
+include Makefile.rules

lldb/test/API/functionalities/data-formatter/swift/date/TestSwiftDateFormatters.py

@@ -0,0 +1,34 @@
+"""
+Test Foundation.Date summary strings.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+
+import sys
+
+
+class TestCase(TestBase):
+    @swiftTest
+    def test_swift_date_formatters(self):
+        """Test Date summary strings."""
+        self.build()
+
+        _ = lldbutil.run_to_source_breakpoint(
+            self, "break here", lldb.SBFileSpec("main.swift")
+        )
+
+        self.expect(
+            "v date",
+            startstr="(Foundation.Date) date = 1999-11-05 23:17:00 UTC",
+        )
+
+        if sys.platform != "win32":
+            return
+
+        self.expect(
+            "v nsdate",
+            startstr="(Foundation.NSDate) date = 1999-11-05 23:17:00 UTC",
+        )

lldb/test/API/functionalities/data-formatter/swift/date/main.swift

@@ -0,0 +1,16 @@
+import Foundation
+
+let paris = TimeZone(identifier: "Europe/Paris")!
+
+var comps = DateComponents()
+comps.year = 1999
+comps.month = 11
+comps.day = 6
+comps.hour = 0
+comps.minute = 17
+comps.timeZone = paris
+
+let date = Calendar(identifier: .gregorian).date(from: comps)!
+let nsdate = date as NSDate
+
+print("break here")