Skip to content

Add a Refactoring Action for Converting Implicitly Unwrapped Optionals to Proper Optionals #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CodaFi opened this issue May 18, 2024 · 6 comments · May be fixed by #1539
Open

Add a Refactoring Action for Converting Implicitly Unwrapped Optionals to Proper Optionals #1320

CodaFi opened this issue May 18, 2024 · 6 comments · May be fixed by #1539
Labels
code action Code action provided by LSP enhancement New feature or request

Comments

@CodaFi
Copy link
Contributor

CodaFi commented May 18, 2024 •
edited
Loading

Description

Add a refactoring action that converts T! to T? for all types T. At first blush, this appears to be possible by converting ImplicitlyUnwrappedOptionalTypeSyntax nodes to OptionalTypeSyntax nodes without changing the underlying type syntax for T.

As an aside, I think we may not necessarily want to go the other way (T? to T!) since it's generally not great Swift style.
@CodaFi CodaFi added enhancement New feature or request good first issue Good for newcomers code action Code action provided by LSP labels May 18, 2024
@ahoppen
Copy link
Member

ahoppen commented May 18, 2024

Synced to Apple’s issue tracker as rdar://128310729

@ahoppen ahoppen changed the title Add a Refactoring Action for Converting IUOs to Proper Optionals Add a Refactoring Action for Converting implicitly unwrapped optionals to proper optionals Jun 8, 2024
@ahoppen ahoppen changed the title Add a Refactoring Action for Converting implicitly unwrapped optionals to proper optionals Add a Refactoring Action for Converting Implicitly Unwrapped Optionals to Proper Optionals Jun 8, 2024
AppAppWorks added a commit to AppAppWorks/sourcekit-lsp that referenced this issue Jun 29, 2024
@AppAppWorks
Convert implicitly unwrapped optionals to proper optionals swiftlang#…
c8ce60b 
…1320

- created ConvertIUOToProperOptional that will suggest a conversion when the token in concern is
    - an IUO;
    - a direct child of an IUO; or
    - a direct child of the wrappedType of an IUO.
- registered in SyntaxCodeActions.allSyntaxCodeActions
- added a test in CodeActionTests
- added ConvertIUOToProperOptional.swift to CMakeLists of SourceKitLSP
@AppAppWorks AppAppWorks linked a pull request Jun 29, 2024 that will close this issue
Draft
AppAppWorks added a commit to AppAppWorks/sourcekit-lsp that referenced this issue Jul 1, 2024
@AppAppWorks
Convert implicitly unwrapped optionals to proper optionals swiftlang#…
e772363 
…1320

- created ConvertImplicitlyUnwrappedOptionalToOptional that will suggest a conversion when the token in concern is
    - an IUO;
    - a direct child of an IUO; or
    - a direct child of the wrappedType of an IUO.
- registered in SyntaxCodeActions.allSyntaxCodeActions
- added a test in CodeActionTests
- added ConvertImplicitlyUnwrappedOptionalToOptional.swift to CMakeLists of SourceKitLSP
@AbdAlRahmanGad
Copy link
Contributor

Hi @ahoppen,

I'm trying to contribute to sourcekit-lsp.

Could you please point me to where should I implement this change? and how to test the refactoring action?

Steps I've taken so far, I've fetched the code and built sourcekit-lsp successfully.

@AbdAlRahmanGad
Copy link
Contributor

I've just noticed that there is an old draft PR. Should I work on top of it or should I look for another issue?

@ahoppen ahoppen removed the good first issue Good for newcomers label Feb 28, 2025
@ahoppen
Copy link
Member

ahoppen commented Feb 28, 2025

Great to hear that you’re interested in contributing. Looks like #1539 has been stale for a while, so I think you could pick it up. That conversation has quite a bit of context as well and I think it turned out that the implementation wouldn’t be trivial because it would be the first global refactoring action except for global rename (which has quite a bit of bespoke logic). But I don’t want to discourage you from trying 😉

@AbdAlRahmanGad
Copy link
Contributor

Is it okay if I worked on issue #1246 as it's the only good first issue right now?

@ahoppen
Copy link
Member

ahoppen commented Mar 3, 2025

Yes, please go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code action Code action provided by LSP enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert implicitly unwrapped optionals to proper optionals AppAppWorks/sourcekit-lsp
3 participants
@CodaFi @ahoppen @AbdAlRahmanGad