Skip to content

Commit aacc68d

Browse files
committed
Properly annotate fallthrough in kevent backend.
Building dispatch from swift sets -Werror -Wimplicit-fallthrough. It is not enough to just comment the fallthrough; we have elsewhere defined DISPATCH_FALLTHROUGH, so we might as well use it.
1 parent 0e0a6b7 commit aacc68d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/event/event_kevent.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ _dispatch_kq_poll(dispatch_wlh_t wlh, dispatch_kevent_t ke, int n,
761761
switch (err) {
762762
case ENOMEM:
763763
_dispatch_temporary_resource_shortage();
764-
/* FALLTHROUGH */
764+
DISPATCH_FALLTHROUGH;
765765
case EINTR:
766766
goto retry;
767767
case EBADF:
@@ -772,7 +772,7 @@ _dispatch_kq_poll(dispatch_wlh_t wlh, dispatch_kevent_t ke, int n,
772772
(flags & KEVENT_FLAG_DYNAMIC_KQ_MUST_EXIST)) {
773773
return 0;
774774
}
775-
/* FALLTHROUGH */
775+
DISPATCH_FALLTHROUGH;
776776
#endif // DISPATCH_USE_KEVENT_WORKLOOP
777777
default:
778778
DISPATCH_CLIENT_CRASH(err, "Unexpected error from kevent");
@@ -1441,7 +1441,7 @@ _dispatch_kq_fill_workloop_event(dispatch_kevent_t ke, int which,
14411441
switch (which) {
14421442
case DISPATCH_WORKLOOP_ASYNC_FROM_SYNC:
14431443
fflags |= NOTE_WL_END_OWNERSHIP;
1444-
/* FALLTHROUGH */
1444+
DISPATCH_FALLTHROUGH;
14451445
case DISPATCH_WORKLOOP_ASYNC:
14461446
case DISPATCH_WORKLOOP_ASYNC_DISCOVER_SYNC:
14471447
case DISPATCH_WORKLOOP_ASYNC_QOS_UPDATE:
@@ -1465,10 +1465,10 @@ _dispatch_kq_fill_workloop_event(dispatch_kevent_t ke, int which,
14651465

14661466
case DISPATCH_WORKLOOP_ASYNC_LEAVE_FROM_SYNC:
14671467
fflags |= NOTE_WL_END_OWNERSHIP;
1468-
/* FALLTHROUGH */
1468+
DISPATCH_FALLTHROUGH;
14691469
case DISPATCH_WORKLOOP_ASYNC_LEAVE_FROM_TRANSFER:
14701470
fflags |= NOTE_WL_IGNORE_ESTALE;
1471-
/* FALLTHROUGH */
1471+
DISPATCH_FALLTHROUGH;
14721472
case DISPATCH_WORKLOOP_ASYNC_LEAVE:
14731473
dispatch_assert(!_dq_state_is_enqueued_on_target(dq_state));
14741474
action = EV_ADD | EV_DELETE | EV_ENABLE;

0 commit comments

Comments
 (0)