TRD_cleanup_code

Author: mcmpp

deps.edn

@@ -2,8 +2,8 @@
   :paths [
     ; in case you get the error `All dirs should be absolute`, you forgot to define an absolute project-dir like so:
     ; clojure -X:build :project-dir "\"$(pwd)\""
-    "/home/mikel/Documents/metabase-teradata-driver2/metabase-teradata-driver/src"
-    "/home/mikel/Documents/metabase-teradata-driver2/metabase-teradata-driver/resources"
+    "src"
+    "resources"
   ]
 
   :deps {

resources/metabase-plugin.yaml

@@ -37,7 +37,7 @@ driver:
         - additional-options
         - placeholder: e.g. COPLAST=OFF
     # required in order that `Choose when syncs and scans happen` shows up in database options afterwards
-    # (during first time setup, you only see `Periodically refingerprint tables` in metabase v0.45.2
+    # (during first time setup, you only see `Periodically refingerprint tables` in metabase v0.45.3
     # the option `Choose when syncs and scans happen` only shows up later in admin -> Database -> advanced options)
     - default-advanced-options
   connection-properties-include-tunnel-config: false

src/metabase/driver/teradata.clj

@@ -101,7 +101,6 @@
                   (some->> table-name (driver/escape-entity-name-for-metadata driver))
                   nil)
     (fn [^ResultSet rs]
-      ;; https://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getColumns(java.lang.String,%20java.lang.String,%20java.lang.String,%20java.lang.String)
       #(let [default            (.getString rs "COLUMN_DEF")
              no-default?        (contains? #{nil "NULL" "null"} default)
              nullable           (.getInt rs "NULLABLE")
@@ -120,7 +119,6 @@
   "In some rare cases `:column_name` is blank (eg. SQLite's views with group by) fallback to sniffing the type from a
   SELECT * query."
   [driver ^Connection conn table-schema table-name]
-  ;; some DBs (:sqlite) don't actually return the correct metadata for LIMIT 0 queries
   (let [[sql & params] (sql-jdbc.sync.interface/fallback-metadata-query driver table-schema table-name)]
     (reify clojure.lang.IReduceInit
       (reduce [_ rf init]