Introduce PHPStan

Author: szepeviktor

Diff for: .travis.yml

@@ -4,17 +4,19 @@ php:
   - 7.1
   - 7.2
   - 7.3
+
 services:
   - redis
+
 install:
   - echo 'no' | pecl install -f redis
   - wget https://github.com/swoole/swoole-src/archive/v4.3.3.tar.gz -O swoole.tar.gz && mkdir -p swoole && tar -xf swoole.tar.gz -C swoole --strip-components=1 && rm swoole.tar.gz && cd swoole && phpize && ./configure && make -j$(nproc) && make install && cd -
   - echo "extension = swoole.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini
 
 before_script:
   - composer config -g process-timeout 900 && composer update
+  - composer require --dev phpstan/phpstan-shim
   - phpenv config-rm xdebug.ini
 
-
 script:
   - composer test

Diff for: app/Console/Command/AgentCommand.php

@@ -76,7 +76,7 @@ public function updateConfigFile(array $data): void
 //            $server = bean('rpcServer');
 //            $server->restart();
 
-            /* @var WebSocketServer $server */
+            /** @var WebSocketServer $server */
             $server = bean('wsServer');
             $server->restart();
         }

Diff for: app/Http/Controller/BeanController.php

@@ -32,7 +32,7 @@ public function request(): array
     {
         $id = (string)Co::tid();
 
-        /* @var RequestBean $request*/
+        /** @var RequestBean $request*/
         $request = BeanFactory::getRequestBean('requestBean', $id);
         return $request->getData();
     }

Diff for: app/Http/Controller/DbModelController.php

@@ -130,7 +130,7 @@ public function batchUpdate()
         $users = User::find(array_column($values, 'id'));
 
         $updateResults = [];
-        /* @var User $user */
+        /** @var User $user */
         foreach ($users as $user) {
             $updateResults[$user->getId()] = true;
             if ($user->getAge() != $values[$user->getId()]['age']) {

Diff for: app/Http/Controller/RespController.php

@@ -24,7 +24,7 @@ class RespController
      */
     public function cookie(): Response
     {
-        /* @var Response $resp */
+        /** @var Response $resp */
         $resp = Context::mustGet()->getResponse();
 
         return $resp->setCookie('c-name', 'c-value')->withData(['hello']);

Diff for: app/Listener/DeregisterServiceListener.php

@@ -44,7 +44,7 @@ class DeregisterServiceListener implements EventHandlerInterface
      */
     public function handle(EventInterface $event): void
     {
-        /* @var HttpServer $httpServer */
+        /** @var HttpServer $httpServer */
         $httpServer = $event->getTarget();
 
 //        $this->agent->deregisterService('swoft');

Diff for: app/Listener/ModelSavedListener.php

@@ -24,7 +24,7 @@ class ModelSavedListener implements EventHandlerInterface
      */
     public function handle(EventInterface $event): void
     {
-        /* @var Model $modelStatic */
+        /** @var Model $modelStatic */
         $modelStatic = $event->getTarget();
 
         if ($modelStatic instanceof User) {

Diff for: app/Listener/RanListener.php

@@ -28,7 +28,7 @@ class RanListener implements EventHandlerInterface
      */
     public function handle(EventInterface $event): void
     {
-        /* @var Connection $connection */
+        /** @var Connection $connection */
         $connection = $event->getTarget();
 
         $querySql = $event->getParam(0);

Diff for: app/Listener/RegisterServiceListener.php

@@ -36,7 +36,7 @@ class RegisterServiceListener implements EventHandlerInterface
      */
     public function handle(EventInterface $event): void
     {
-        /* @var HttpServer $httpServer */
+        /** @var HttpServer $httpServer */
         $httpServer = $event->getTarget();
 
         $service = [

Diff for: app/Listener/UserSavingListener.php

@@ -23,7 +23,7 @@ class UserSavingListener implements EventHandlerInterface
     public function handle(EventInterface $event): void
     {
 
-        /* @var User $user */
+        /** @var User $user */
         $user = $event->getTarget();
 
         /**

Diff for: app/WebSocket/Chat/HomeController.php

@@ -27,7 +27,7 @@ public function index(): void
     /**
      * Message command is: 'home.echo'
      *
-     * @param $data
+     * @param string $data
      * @MessageMapping()
      */
     public function echo($data): void
@@ -38,7 +38,7 @@ public function echo($data): void
     /**
      * Message command is: 'home.ar'
      *
-     * @param $data
+     * @param string $data
      * @MessageMapping("ar")
      *
      * @return string

Diff for: composer.json

@@ -54,7 +54,10 @@
     "post-root-package-install": [
       "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
     ],
-    "test": "./vendor/bin/phpunit -c phpunit.xml",
+    "test": [
+      "./vendor/bin/phpstan analyze",
+      "./vendor/bin/phpunit -c phpunit.xml",
+    ],
     "cs-fix": "./vendor/bin/php-cs-fixer fix $1"
   }
 }

Diff for: phpstan.neon.dist

@@ -0,0 +1,16 @@
+includes:
+    - phar://phpstan.phar/conf/bleedingEdge.neon
+parameters:
+    level: max
+    inferPrivatePropertyTypeFromConstructor: true
+    paths:
+        - %currentWorkingDirectory%/app/
+    autoload_files:
+        - %currentWorkingDirectory%/test/bootstrap.php
+    autoload_directories:
+        - %currentWorkingDirectory%/vendor/swoft/swoole-ide-helper/src/namespace/
+    dynamicConstantNames:
+        - APP_DEBUG
+    ignoreErrors:
+        # Variable type
+        - '#^Call to an undefined method Swoft\\Contract\\ContextInterface::get\S+\(\)\.$#'

Diff for: test/bootstrap.php

@@ -1,2 +1,3 @@
 <?php
 
+define('APP_DEBUG', true);