Merge pull request #466 from isuruf/func

Raise error on wrong number of arguments to Function and add name property

Author: isuruf

symengine/lib/symengine_wrapper.in.pyx

@@ -2415,8 +2415,15 @@ class Pow(Expr):
 class Function(Expr):
 
     def __new__(cls, *args, **kwargs):
-        if cls == Function and len(args) == 1:
-            return UndefFunction(args[0])
+        if cls == Function:
+            nargs = len(args)
+            if nargs == 0:
+                raise TypeError("Required at least one argument to Function")
+            elif nargs == 1:
+                return UndefFunction(args[0])
+            elif nargs > 1:
+                raise TypeError(f"Unexpected extra arguments {args[1:]}.")
+
         return super(Function, cls).__new__(cls)
 
     @property
@@ -2837,6 +2844,10 @@ class FunctionSymbol(Function):
         name = deref(X).get_name().decode("utf-8")
         return str(name)
 
+    @property
+    def name(Basic self):
+        return self.get_name()
+
     def _sympy_(self):
         import sympy
         name = self.get_name()

symengine/tests/test_functions.py

@@ -103,6 +103,18 @@ def test_derivative():
     assert i == fxy.diff(y, 1, x)
 
 
+def test_function():
+    x = Symbol("x")
+    fx = Function("f")(x)
+    assert fx == function_symbol("f", x)
+
+    raises(TypeError, lambda: Function("f", "x"))
+    raises(TypeError, lambda: Function("f", x))
+    raises(TypeError, lambda: Function())
+
+    assert fx.name == "f"
+
+
 def test_abs():
     x = Symbol("x")
     e = abs(x)