bug #1669 Fix the E2E tests workflow (javiereguiluz)

This PR was merged into the main branch.

Discussion
----------

Fix the E2E tests workflow

Fixes #1662

The daily E2E workflow has been failing every day since June 26. This PR fixes the root cause and makes two improvements to the workflow.

**Why the tests were failing**

Only the Test Composer Create Project job failed: the install worked, bin/console about worked, the server started, but the first request to the homepage returned 502 Bad Gateway. The root cause is a PHP-FPM segfault caused by the opcache JIT:

```
php-fpm8.5[5018]: segfault at 7f273e598ffc ip 00005581c66e35a6 ... in php-fpm8.5
```

The conditions that had to combine:

* This job is the only one using php-version: latest (currently PHP 8.5.7); the other jobs pin PHP 8.4 and kept passing.
* setup-php enables the opcache JIT by default (opcache.jit=1235, 256M buffer). Stock PHP builds (official Docker images, sury packages, Homebrew) ship with the JIT disabled, which is why this was not reproducible outside GitHub runners
* PHP 8.5.7's JIT crashes on a hot code path in Symfony 8.1. Failures started exactly when demo v3.1.0 (the Symfony 8.1 upgrade) was released on June 25: the last green run installed v3.0.2/Symfony 8.0 on the same PHP 8.5.7. PHP 8.4's JIT is not affected.

The crashed FPM worker made the Symfony CLI proxy return 502; an immediate retry succeeded (fresh worker), which is how the crash was narrowed down.

**Changes**

* Disable the opcache JIT in the composer job (ini-values: opcache.jit=disable)
* Add a "Show diagnostics on failure" step to each test job: PHP version and key ini values, a retry of the request (to tell first-request-only failures from persistent ones), the application logs and the kernel messages (dmesg, which is what exposed the segfault). Until now the workflow captured nothing on failure, making issues like this one invisible.
* Create at most one E2E failure issue at a time: previously the workflow created one issue per day (see #1663–#1668, all closed manually). Now, if any issue whose title starts with E2E Test Failure is still open, the workflow doesn't create a new issue.

Commits
-------

7e7f61b Fix the E2E tests workflow

Author: javiereguiluz

.github/workflows/end_to_end_tests.yaml

@@ -42,6 +42,23 @@ jobs:
                   curl --fail --max-time 5 --no-progress-meter --output home.html -v http://127.0.0.1:8000/
                   symfony server:stop
 
+            - name: Show diagnostics on failure
+              if: ${{ failure() }}
+              working-directory: ${{ github.job }}
+              run: |
+                  php -v
+                  php -i | grep -E "memory_limit|opcache.enable|opcache.jit" || true
+                  # retry without --fail to see if the failure is first-request-only
+                  curl -sS --max-time 15 -o /tmp/retry.html -w 'retry: %{http_code} in %{time_total}s\n' http://127.0.0.1:8000/ || true
+                  head -c 300 /tmp/retry.html || true
+                  echo '===== app logs (filtered) ====='
+                  grep -hvE "security.DEBUG|http_client.INFO|cache.INFO" var/log/*.log | tail -n 60 || true
+                  echo '===== symfony CLI / PHP-FPM logs ====='
+                  find "$HOME" -maxdepth 6 -type d -name "*symfony5*" 2>/dev/null || true
+                  for f in $(find "$HOME/.symfony5" "${XDG_DATA_HOME:-$HOME/.local/share}/symfony5" "${XDG_CONFIG_HOME:-$HOME/.config}/symfony5" -type f -name "*.log" 2>/dev/null); do echo "--- $f"; cat "$f"; done
+                  echo '===== kernel messages (crashes / OOM) ====='
+                  sudo dmesg 2>/dev/null | tail -n 30 || true
+
     test-composer-create-project:
         name: Test Composer Create Project
         runs-on: ubuntu-latest
@@ -52,6 +69,12 @@ jobs:
               with:
                   coverage: none
                   extensions: none, ctype, dom, iconv, intl, mbstring, pdo_sqlite, simplexml, tokenizer, xml, xmlwriter
+                  # setup-php enables the opcache JIT by default, but stock PHP disables it.
+                  # The tracing JIT crashes PHP-FPM while serving the first request of a
+                  # Symfony 8.1 app (reproduced with PHP 8.4 and 8.5, on x86_64 and arm64),
+                  # which made this job fail with a 502 error. Disable the JIT to test the
+                  # default PHP configuration that users actually run.
+                  ini-values: opcache.jit=disable
                   php-version: latest
                   tools: symfony-cli
 
@@ -66,6 +89,23 @@ jobs:
                   curl --fail --max-time 5 --no-progress-meter --output home.html -v http://127.0.0.1:8000/
                   symfony server:stop
 
+            - name: Show diagnostics on failure
+              if: ${{ failure() }}
+              working-directory: ${{ github.job }}
+              run: |
+                  php -v
+                  php -i | grep -E "memory_limit|opcache.enable|opcache.jit" || true
+                  # retry without --fail to see if the failure is first-request-only
+                  curl -sS --max-time 15 -o /tmp/retry.html -w 'retry: %{http_code} in %{time_total}s\n' http://127.0.0.1:8000/ || true
+                  head -c 300 /tmp/retry.html || true
+                  echo '===== app logs (filtered) ====='
+                  grep -hvE "security.DEBUG|http_client.INFO|cache.INFO" var/log/*.log | tail -n 60 || true
+                  echo '===== symfony CLI / PHP-FPM logs ====='
+                  find "$HOME" -maxdepth 6 -type d -name "*symfony5*" 2>/dev/null || true
+                  for f in $(find "$HOME/.symfony5" "${XDG_DATA_HOME:-$HOME/.local/share}/symfony5" "${XDG_CONFIG_HOME:-$HOME/.config}/symfony5" -type f -name "*.log" 2>/dev/null); do echo "--- $f"; cat "$f"; done
+                  echo '===== kernel messages (crashes / OOM) ====='
+                  sudo dmesg 2>/dev/null | tail -n 30 || true
+
     test-git-clone-installation:
         name: Test Git Clone Installation
         runs-on: ubuntu-latest
@@ -93,6 +133,23 @@ jobs:
                   curl --fail --max-time 5 --no-progress-meter --output home.html -v http://127.0.0.1:8000/
                   symfony server:stop
 
+            - name: Show diagnostics on failure
+              if: ${{ failure() }}
+              working-directory: ${{ github.job }}
+              run: |
+                  php -v
+                  php -i | grep -E "memory_limit|opcache.enable|opcache.jit" || true
+                  # retry without --fail to see if the failure is first-request-only
+                  curl -sS --max-time 15 -o /tmp/retry.html -w 'retry: %{http_code} in %{time_total}s\n' http://127.0.0.1:8000/ || true
+                  head -c 300 /tmp/retry.html || true
+                  echo '===== app logs (filtered) ====='
+                  grep -hvE "security.DEBUG|http_client.INFO|cache.INFO" var/log/*.log | tail -n 60 || true
+                  echo '===== symfony CLI / PHP-FPM logs ====='
+                  find "$HOME" -maxdepth 6 -type d -name "*symfony5*" 2>/dev/null || true
+                  for f in $(find "$HOME/.symfony5" "${XDG_DATA_HOME:-$HOME/.local/share}/symfony5" "${XDG_CONFIG_HOME:-$HOME/.config}/symfony5" -type f -name "*.log" 2>/dev/null); do echo "--- $f"; cat "$f"; done
+                  echo '===== kernel messages (crashes / OOM) ====='
+                  sudo dmesg 2>/dev/null | tail -n 30 || true
+
     notify-on-failure:
         if: ${{ always() && contains(needs.*.result, 'failure') }}
         name: Notify on Failure
@@ -151,17 +208,14 @@ jobs:
                         });
                       }
 
-                      // Reuse an open issue for today if it already exists to avoid duplicates
+                      // Skip if any E2E failure issue is already open, to avoid daily noise
                       const { data: issues } = await github.rest.issues.listForRepo({
-                        owner, repo, state: 'open', labels: labelName, per_page: 100
+                        owner, repo, state: 'open', per_page: 100
                       });
-                      const existing = issues.find(i => i.title === title);
-
+                      const existing = issues.find(i => i.title.startsWith('E2E Test Failure'));
                       if (existing) {
-                        await github.rest.issues.createComment({
-                          owner, repo, issue_number: existing.number,
-                          body: `Another failing run detected.\n\n${body}`
-                        });
-                      } else {
-                        await github.rest.issues.create({ owner, repo, title, body, labels: [labelName] });
+                        core.info(`Issue #${existing.number} about E2E failures is still open; not creating another one.`);
+                        return;
                       }
+
+                      await github.rest.issues.create({ owner, repo, title, body, labels: [labelName] });