Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpKernel] Support Uid in #[MapQueryParameter] #20626

Closed
fabpot opened this issue Feb 7, 2025 · 0 comments · Fixed by #20784
Closed

[HttpKernel] Support Uid in #[MapQueryParameter] #20626

fabpot opened this issue Feb 7, 2025 · 0 comments · Fixed by #20784
Labels
hasPR A Pull Request has already been submitted for this issue. HttpKernel
Milestone
7.3

Comments

@fabpot
Copy link
Member

fabpot commented Feb 7, 2025

Q A
Feature PR symfony/symfony#58717
PR author(s) @seb-jean
Merged in 7.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.3 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.3 milestone Feb 7, 2025
This was referenced Mar 20, 2025
Merged
Merged
javiereguiluz added a commit that referenced this issue Mar 21, 2025
@javiereguiluz
minor #20783 [HttpKernel] Document supported types `#[MapQueryParamet…
4dd7073 
…er]` (alamirault)

This PR was merged into the 6.4 branch.

Discussion
----------

[HttpKernel] Document supported types `#[MapQueryParameter]`

Before doing #20626 I think we need to document already supported types by `#[MapQueryParameter]` attribute

https://github.com/symfony/symfony/blob/5a9a3515b78f1a499e8e5f86636cbdc205067e24/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php#L22

Commits
-------

d873aec Document supported types #[MapQueryParameter]
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpKernel
Projects
None yet
Milestone
7.3
Development

Successfully merging a pull request may close this issue.

[HttpKernel] Support Uid in #[MapQueryParameter] alamirault/symfony-docs
3 participants
@fabpot @xabbuh @carsonbot