Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] report issues in ux:icons:warm-cache #2668

Open
dbu opened this issue Mar 30, 2025 · 1 comment
Open

[Icons] report issues in ux:icons:warm-cache #2668

dbu opened this issue Mar 30, 2025 · 1 comment

Comments

@dbu
Copy link
Contributor

dbu commented Mar 30, 2025

when the http client is not available and an iconify icon is not already in the cache, the command does not indicate there is a problem:

Image

single -v still almost no indication of problems, except that the other icon in my templates is not mentioned.
Image

double -vv mentions the other icon and then has no "warmed" message for it, but does not explicitly state there was a problem
Image

i would expect the command to fail, or at least output a fat warning even without extra verbosity that some icons where not found (and a check for HttpClient that mentions its absence)

@kbond
Copy link
Member

kbond commented Apr 5, 2025

This is a tricky one. The logic to find icons in your project looks at any string that matches something:something (even if it's not in a ux_icon()). The reason for this is to catch icons set in twig variables (ie ux_icons(error ? 'mdi:error' : 'mdi:success'). I'd like to improve this but not sure how...

In #2678, I've at least listed the not found icons when running ux:icons:warm-cache -v. Right now, I think that's the best we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants