From d36b98e83169e54d292ce43041cb5e34160e0f10 Mon Sep 17 00:00:00 2001
From: stehled <eda.stehlik@seznam.cz>
Date: Thu, 6 Mar 2025 08:54:26 +0100
Subject: [PATCH] [LiveComponent] `ComponentWithFormTrait` now correctly checks
 for a `TranslatableInterface` placeholder for `<select>` elements, close
 #2621
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Simon André <smn.andre@gmail.com>
---
 src/LiveComponent/CHANGELOG.md                   | 1 +
 src/LiveComponent/src/ComponentWithFormTrait.php | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/LiveComponent/CHANGELOG.md b/src/LiveComponent/CHANGELOG.md
index 832c31885f4..a05311bbb0a 100644
--- a/src/LiveComponent/CHANGELOG.md
+++ b/src/LiveComponent/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 2.25.0
 
 -   Add support for [Symfony UID](https://symfony.com/doc/current/components/uid.html) hydration/dehydration
+-   `ComponentWithFormTrait` now correctly checks for a `TranslatableInterface` placeholder for `<select>` elements
 
 ## 2.23.0
 
diff --git a/src/LiveComponent/src/ComponentWithFormTrait.php b/src/LiveComponent/src/ComponentWithFormTrait.php
index 00c98419263..fff01e0b73b 100644
--- a/src/LiveComponent/src/ComponentWithFormTrait.php
+++ b/src/LiveComponent/src/ComponentWithFormTrait.php
@@ -16,6 +16,7 @@
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\Form\FormView;
 use Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException;
+use Symfony\Contracts\Translation\TranslatableInterface;
 use Symfony\UX\LiveComponent\Attribute\LiveProp;
 use Symfony\UX\LiveComponent\Attribute\PreReRender;
 use Symfony\UX\LiveComponent\Util\LiveFormUtility;
@@ -286,7 +287,8 @@ private function extractFormValues(FormView $formView): array
                 )
                 && !$child->vars['expanded']                // is a <select>     (not a radio/checkbox)
                 && !$child->vars['multiple']                // is not multiple
-                && !\is_string($child->vars['placeholder'])  // has no placeholder (empty string is valid)
+                && !\is_string($child->vars['placeholder']) // has no placeholder (empty string is valid)
+                && !$child->vars['placeholder'] instanceof TranslatableInterface // has no placeholder (translatable interface is valid)
             ) {
                 $choices = $child->vars['preferred_choices'] ?: $child->vars['choices']; // preferred_choices has precedence, as they rendered before regular choices
                 do {