6.5.7-t2 does not wake from suspend

[aboulfad]

Issue
MacBook Pro (MBP) always freezes/crashes when using suspend in Linux-t2-ubuntu. This is evident when re-starting, the boot screen shows fsck (or equivalent) running as well as the MBP bong & login to Linux. I included dmesg log as well screenshot from boot process.

MBP Info
MacBook Pro 2018, i7
Model ID: MacBookPro15,2
Controller Firmware version: 21P365
OS: Sonoma (14.0)

T2Linux Info
kernel: 6.5.7-t2
OS: Ubuntu 23.10 (Mantic Minotaur)

dmesg.log

[AdityaGarg8]

Suspend has been broken since macOS Sonoma

[aboulfad]

Thanks, should I keep this issue open ? For other who may have trouble with this, in the meantime the behavior can be changed for lid close = ignore or lock. reference

[AdityaGarg8]

Can be kept open

[rydymth]

Hi there!,
I am having a similar problem but for some reason, before apple decided to screw up the wifi and bluetooth firmware packages with the macos sonoma, i believe i have taken a backup of the previous firmware packages. You can download from here.
I am yet to figure out a way to do these things. With the latest kernel that is 6.6 something, my bluetooth stops working so i go back to previous kernel that was working very well for me before sonoma that was 6.3.6.
I will keep on trying to get my suspend working. I think ill replace my current OS with a new one with the older kernel.
Ill update if this worked for me.

[AdityaGarg8]

I guess there is a regression in kernel 6.5 that broke Bluetooth for some models. Can you see if you get Bluetooth working on a 6.4.x and a 6.5 kernel @rydymth

[rydymth]

Hi!
The bluetooth works on all 6.4.* kernel. I tested on 6.4.7 and 6.4.8. It works just fine.
It however doesnt work on 6.5.*. I have tested on 6.5.2 and 6.5.8...
And it does not work on 6.6.1 either...

[AdityaGarg8]

Can you share your complete journalctl -k from a 6.4 and 6.5 kernel. You can use pastebin to share

[rydymth]

HI!
Yes for sure!
Here is the journalctl for linux6.4.8 where everythin works except suspend.
And here is the journalctl for linux6.5.2 where bluetooth and suspend are not working.
There is an array index out of bounds error in both of them. Im not able to understand much but will attempt to debug more. There is a reference to this: try_to_wake_up+0x292/0x6c0 in the stack trace. Would this be the issue?
I am unable to find why bluetooth isnt working in the 6.5.2 one...

[AdityaGarg8]

I've filed a bug report upstream:

https://lkml.org/lkml/2023/11/13/722

[AdityaGarg8]

Hi @rydymth

Kernel 6.6.1-2 has a patch sent by upstream maintainers to fix Bluetooth on your model. Can you give it a test when it compiles. It should compile after 2.5-3hrs after I send this message.

[rydymth]

Hi @AdityaGarg8!
Just tried the new commit. Still no luck...
It is showing this error everytime i try to load/reload the hci_bcm4377 module:
[ 386.052230] hci_bcm4377 0000:73:00.1: can't disable ASPM; OS doesn't have ASPM control
Dmesg Log Link
Journalctl Log Link

[aboulfad]

Hi, I am a bit confused as to how @rydymth BT’s issue is related to the suspend issue I reported ? Thanks.

[AdityaGarg8]

Hi, I am a bit confused as to how @rydymth BT’s issue is related to the suspend issue I reported ? Thanks.

Its not related to suspend, but is an issue that deserves to be fixed

[aboulfad]

Ok, I guess @rydymth could have created another GH issue, hence my confusion.

[AdityaGarg8]

Hi @AdityaGarg8! Just tried the new commit. Still no luck... It is showing this error everytime i try to load/reload the hci_bcm4377 module: [ 386.052230] hci_bcm4377 0000:73:00.1: can't disable ASPM; OS doesn't have ASPM control Dmesg Log Link Journalctl Log Link

Looks like the UBSAN error got fixed. Got another patch, try 6.6.1-3