Skip to content

Commit 45c7a68

Browse files
committed
Remove redundant lowercase png and svg aliases
1 parent 9218118 commit 45c7a68

File tree

3 files changed

+0
-32
lines changed

3 files changed

+0
-32
lines changed

tableauserverclient/server/request_options.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,8 +512,6 @@ class Resolution:
512512
class Format:
513513
PNG = "PNG"
514514
SVG = "SVG"
515-
png = "PNG"
516-
svg = "SVG"
517515

518516
def __init__(self, imageresolution=None, maxage=-1, viz_height=None, viz_width=None, format=None):
519517
super().__init__(maxage=maxage, viz_height=viz_height, viz_width=viz_width)

test/test_custom_view.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -146,21 +146,6 @@ def test_populate_image_png_format(server: TSC.Server) -> None:
146146
assert response == single_view.image
147147

148148

149-
def test_populate_image_svg_format_lowercase_alias(server: TSC.Server) -> None:
150-
server.version = "3.29"
151-
response = b"<svg>test</svg>"
152-
with requests_mock.mock() as m:
153-
m.get(
154-
server.custom_views.baseurl + "/d79634e1-6063-4ec9-95ff-50acbf609ff5/image?format=SVG",
155-
content=response,
156-
)
157-
single_view = TSC.CustomViewItem()
158-
single_view._id = "d79634e1-6063-4ec9-95ff-50acbf609ff5"
159-
req_option = TSC.ImageRequestOptions(format=TSC.ImageRequestOptions.Format.svg)
160-
server.custom_views.populate_image(single_view, req_option)
161-
assert response == single_view.image
162-
163-
164149
def test_populate_image_format_unsupported_version(server: TSC.Server) -> None:
165150
from tableauserverclient.server.endpoint.exceptions import UnsupportedAttributeError
166151

test/test_view.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -268,21 +268,6 @@ def test_populate_image_png_format(server: TSC.Server) -> None:
268268
assert response == single_view.image
269269

270270

271-
def test_populate_image_svg_format_lowercase_alias(server: TSC.Server) -> None:
272-
server.version = "3.29"
273-
response = b"<svg>test</svg>"
274-
with requests_mock.mock() as m:
275-
m.get(
276-
server.views.baseurl + "/d79634e1-6063-4ec9-95ff-50acbf609ff5/image?format=SVG",
277-
content=response,
278-
)
279-
single_view = TSC.ViewItem()
280-
single_view._id = "d79634e1-6063-4ec9-95ff-50acbf609ff5"
281-
req_option = TSC.ImageRequestOptions(format=TSC.ImageRequestOptions.Format.svg)
282-
server.views.populate_image(single_view, req_option)
283-
assert response == single_view.image
284-
285-
286271
def test_populate_image_format_unsupported_version(server: TSC.Server) -> None:
287272
server.version = "3.28"
288273
response = POPULATE_PREVIEW_IMAGE.read_bytes()

0 commit comments

Comments
 (0)