Skip to content

Commit b0f47c3

Browse files
committed
Refactor model classes
1 parent c45da2b commit b0f47c3

File tree

6 files changed

+15
-26
lines changed

6 files changed

+15
-26
lines changed

src/main/java/com/github/tadayosi/torchserve/client/impl/DefaultManagement.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.github.tadayosi.torchserve.client.Management;
77
import com.github.tadayosi.torchserve.client.management.api.DefaultApi;
88
import com.github.tadayosi.torchserve.client.management.invoker.ApiClient;
9+
import com.github.tadayosi.torchserve.client.management.model.DescribeModel200ResponseInner;
910
import com.github.tadayosi.torchserve.client.model.Api;
1011
import com.github.tadayosi.torchserve.client.model.ApiException;
1112
import com.github.tadayosi.torchserve.client.model.ModelDetail;
@@ -91,7 +92,8 @@ public Response setAutoScale(String modelName, String modelVersion, SetAutoScale
9192
@Override
9293
public List<ModelDetail> describeModel(String modelName) throws ApiException {
9394
try {
94-
return ModelDetail.fromList(api.describeModel(modelName));
95+
List<DescribeModel200ResponseInner> response = api.describeModel(modelName);
96+
return response.stream().map(ModelDetail::from).toList();
9597
} catch (com.github.tadayosi.torchserve.client.management.invoker.ApiException e) {
9698
throw new ApiException(e);
9799
}
@@ -100,7 +102,8 @@ public List<ModelDetail> describeModel(String modelName) throws ApiException {
100102
@Override
101103
public List<ModelDetail> describeModel(String modelName, String modelVersion) throws ApiException {
102104
try {
103-
return ModelDetail.fromList(api.versionDescribeModel(modelName, modelVersion));
105+
List<DescribeModel200ResponseInner> response = api.versionDescribeModel(modelName, modelVersion);
106+
return response.stream().map(ModelDetail::from).toList();
104107
} catch (com.github.tadayosi.torchserve.client.management.invoker.ApiException e) {
105108
throw new ApiException(e);
106109
}

src/main/java/com/github/tadayosi/torchserve/client/model/Model.java

-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
package com.github.tadayosi.torchserve.client.model;
22

3-
import java.util.List;
4-
import java.util.stream.Collectors;
5-
63
import com.github.tadayosi.torchserve.client.management.model.ListModels200ResponseModelsInner;
74
import org.slf4j.Logger;
85
import org.slf4j.LoggerFactory;
@@ -24,10 +21,6 @@ public static Model from(ListModels200ResponseModelsInner src) {
2421
return model;
2522
}
2623

27-
public static List<Model> from(List<ListModels200ResponseModelsInner> src) {
28-
return src.stream().map(Model::from).collect(Collectors.toList());
29-
}
30-
3124
public String getModelName() {
3225
return modelName;
3326
}

src/main/java/com/github/tadayosi/torchserve/client/model/ModelDetail.java

+4-7
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import java.util.ArrayList;
44
import java.util.List;
5-
import java.util.stream.Collectors;
5+
6+
import com.github.tadayosi.torchserve.client.management.model.DescribeModel200ResponseInner;
67

78
public class ModelDetail extends Model {
89

@@ -19,7 +20,7 @@ public class ModelDetail extends Model {
1920
public ModelDetail() {
2021
}
2122

22-
public static ModelDetail from(com.github.tadayosi.torchserve.client.management.model.DescribeModel200ResponseInner src) {
23+
public static ModelDetail from(DescribeModel200ResponseInner src) {
2324
ModelDetail model = new ModelDetail();
2425
model.setModelName(src.getModelName());
2526
model.setModelVersion(src.getModelVersion());
@@ -29,16 +30,12 @@ public static ModelDetail from(com.github.tadayosi.torchserve.client.management.
2930
model.setBatchSize(src.getBatchSize());
3031
model.setMaxBatchDelay(src.getMaxBatchDelay());
3132
model.setStatus(src.getStatus());
32-
model.setWorkers(Worker.from(src.getWorkers()));
33+
model.setWorkers(src.getWorkers().stream().map(Worker::from).toList());
3334
model.setMetrics(Metrics.from(src.getMetrics()));
3435
model.setJobQueueStatus(JobQueueStatus.from(src.getJobQueueStatus()));
3536
return model;
3637
}
3738

38-
public static List<ModelDetail> fromList(List<com.github.tadayosi.torchserve.client.management.model.DescribeModel200ResponseInner> src) {
39-
return src.stream().map(ModelDetail::from).collect(Collectors.toList());
40-
}
41-
4239
public String getModelVersion() {
4340
return modelVersion;
4441
}

src/main/java/com/github/tadayosi/torchserve/client/model/ModelList.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public ModelList() {
1616
public static ModelList from(ListModels200Response inlineResponse2001) {
1717
ModelList modelList = new ModelList();
1818
modelList.setNextPageToken(inlineResponse2001.getNextPageToken());
19-
modelList.setModels(Model.from(inlineResponse2001.getModels()));
19+
modelList.setModels(inlineResponse2001.getModels().stream().map(Model::from).toList());
2020
return modelList;
2121
}
2222

src/main/java/com/github/tadayosi/torchserve/client/model/Response.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
11
package com.github.tadayosi.torchserve.client.model;
22

3+
import com.github.tadayosi.torchserve.client.inference.model.Ping200Response;
4+
import com.github.tadayosi.torchserve.client.management.model.RegisterModel200Response;
5+
36
public class Response {
47

58
private String status;
69

710
public Response() {
811
}
912

10-
public static Response from(com.github.tadayosi.torchserve.client.inference.model.Ping200Response src) {
13+
public static Response from(Ping200Response src) {
1114
Response response = new Response();
1215
response.setStatus(src.getStatus());
1316
return response;
1417
}
1518

16-
public static Response from(com.github.tadayosi.torchserve.client.management.model.RegisterModel200Response src) {
19+
public static Response from(RegisterModel200Response src) {
1720
Response response = new Response();
1821
response.setStatus(src.getStatus());
1922
return response;

src/main/java/com/github/tadayosi/torchserve/client/model/Worker.java

-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
package com.github.tadayosi.torchserve.client.model;
22

3-
import java.util.List;
4-
import java.util.stream.Collectors;
5-
63
import com.github.tadayosi.torchserve.client.management.model.DescribeModel200ResponseInnerWorkersInner;
74

85
public class Worker {
@@ -28,10 +25,6 @@ public static Worker from(DescribeModel200ResponseInnerWorkersInner src) {
2825
return worker;
2926
}
3027

31-
public static List<Worker> from(List<DescribeModel200ResponseInnerWorkersInner> src) {
32-
return src.stream().map(Worker::from).collect(Collectors.toList());
33-
}
34-
3528
public String getId() {
3629
return id;
3730
}

0 commit comments

Comments
 (0)