Skip to content

Able to manually enter hhtp://.../account/login in the address bar when a user is already logged in. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BigMoonTech opened this issue Sep 13, 2022 · 1 comment
Closed

Able to manually enter hhtp://.../account/login in the address bar when a user is already logged in. #24

BigMoonTech opened this issue Sep 13, 2022 · 1 comment
Assignees
@mikeckennedy

Comments

@BigMoonTech
Copy link

If a user is already logged in, they can manually go to the login page even after they are already logged in. Instead, manually going to the login page if logged in should redirect to the account page.
@mikeckennedy
Copy link
Member

Hey @BigMoonTech Thanks for pointing this out. I did miss it during the recording. But you are right that this is the correct behavior. See the associated commit above. It should be fixed now.

@mikeckennedy mikeckennedy self-assigned this Sep 16, 2022
FelixTurtur added a commit to FelixTurtur/data-driven-web-apps-with-flask that referenced this issue Nov 23, 2022
@FelixTurtur
Update dev from master (#2)
0affed0 
* Clean up unused method in cookie auth.

* Clean up number converter util return type.

* Use bson.ObjectID for user management rather than int (from SQLAlchemy)

* Fixes talkpython#24 - Should redirect from login -> account if they are already logged in.

Authored-by: Michael Kennedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeckennedy mikeckennedy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeckennedy @BigMoonTech