tests: enhance functional test with more checks.#77
Conversation
a741dbd to
8e84cfc
Compare
40e36fb to
f47fac3
Compare
taodd
left a comment
There was a problem hiding this comment.
Some minor change required.
@pponnuvel thank you very much for the patch. The osdtrace works great, However, from the log output, it seems radostrace still can't output anything.
Thanks @taodd! I've fixed the issue with radostrace now. All look fine now - please take a look again. Thanks. |
taodd
left a comment
There was a problem hiding this comment.
Except the suggested comments.
The radostrace still doesn't output any trace line in the log file.
I guess it's probably because we need to specify the process id of the microceph.rbd bench command, if that's the case we'll need to adjust the order of step 10 and step 11.
add -p to the radostrace. then we should see the actual tracing data from radostrace
7e18ddb to
496d585
Compare
This only happens with GH runners. Locally it produces the output: Do we know if radostrace every produced any output in the past? We only checked if it runs but not whether it produces any tracing logs. I suspect this has never worked. In any case, it's certainly needs to be investigated. |
|
Confirmed with main too: https://github.com/taodd/cephtrace/actions/runs/22072454615/job/63785379309?pr=80 radostrace doesn't produce any trace output. |
90231c3 to
7b511c9
Compare
I understand the cause now. However, the GH run is trying to attach to the host path which is wrong for microceph: This should work if the "-p" option is specified |
|
The CI failure is due to a version mismatch between the main binaries and the debug symbols: for instance, ceph-common has been updated to 17.2.9-0ubuntu0.22.04.2 in jammy-updates/jammy-security, but the corresponding ceph-common-dbgsym on ddebs.ubuntu.com remains at 17.2.9-0ubuntu0.22.04.1 |
Fixes SET-1807. Fixes taodd#24. Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
2e41e38 to
7bdc3d8
Compare
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com> del
7bdc3d8 to
70a53c4
Compare
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
b85ea5a to
91edb0e
Compare
|
@taodd Tests pass now. Please take a look. |
@pponnuvel radostrace still doesn't produce any real trace line. |
|
f4d53c6 to
f9d80a2
Compare
Thanks @taodd. I have now added further checks for radostrace validation. It's similar to osdtrace but you have any specific checks in mind, I could do them here too. |
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
|
@taodd The problem was that the PID passed to radostrace wasn't the actual rbd process (rather a microceph wrapper). Now radostrace logs are captured: https://github.com/taodd/cephtrace/actions/runs/22638785732/job/65608765918?pr=77#step:7:690 |
Fixes SET-1807.